1204628 - Talos' setup.py does not install psutil into virtualenv

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1) In mozilla-central/testing/talos, run python INSTALL.py to create a virtualenv to run talos in.
2) Run . bin/activate to enter the virtualenv
3) Run talos --help

ER:

Should see help for talos listed.

AR:

I get this:

(talos)localhost:talos mikeconley$ talos --help
Traceback (most recent call last):
  File "/Users/mikeconley/Projects/mozilla-central/testing/talos/bin/talos", line 9, in <module>
    load_entry_point('talos==0.0', 'console_scripts', 'talos')()
  File "build/bdist.macosx-10.8-x86_64/egg/pkg_resources.py", line 357, in load_entry_point

  File "build/bdist.macosx-10.8-x86_64/egg/pkg_resources.py", line 2394, in load_entry_point
    py_version=py_version, platform=platform, **kw
  File "build/bdist.macosx-10.8-x86_64/egg/pkg_resources.py", line 2108, in load

  File "/Users/mikeconley/Projects/mozilla-central/testing/talos/talos/run_tests.py", line 19, in <module>
    from talos.ttest import TTest
  File "/Users/mikeconley/Projects/mozilla-central/testing/talos/talos/ttest.py", line 28, in <module>
    from talos.talos_process import run_browser
  File "/Users/mikeconley/Projects/mozilla-central/testing/talos/talos/talos_process.py", line 7, in <module>
    import psutil
ImportError: No module named psutil

I had to manually install psutil. This should probably be added as a dependency when setting up the virtualenv.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for the info mconley!

Comment 2

[Julien Pagès (:parkouss)]

Yeah, we had that at some time, but don't see it anymore - probably backed out with something else, maybe some test counters.

Easy one, I take care of it.

Comment 3

[Julien Pagès (:parkouss)]

Attachment: MozReview Request: Bug 1204628 - Talos' setup.py does not install psutil into virtualenv.r=jmaher

Bug 1204628 - Talos' setup.py does not install psutil into virtualenv.r=jmaher

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8661064 [details]
MozReview Request: Bug 1204628 - Talos' setup.py does not install psutil into virtualenv.r=jmaher

https://reviewboard.mozilla.org/r/19267/#review17217

awesome

Comment 5

[Julien Pagès (:parkouss)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=937851189428

Comment 7

[Julien Pagès (:parkouss)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5332735b2410b8e7231b3fe34f272c147f5583f
Bug 1204628 - Talos' setup.py does not install psutil into virtualenv.r=jmaher

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c5332735b241