[Accessibility] [Gaia-switch] Update accessibility integration tests for gaia-switch to the latest marionette.

RESOLVED FIXED

Status

Firefox OS
Gaia::Components
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: yzen, Assigned: yzen)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
There were several improvements to marionette landed in gecko and jsmarionette that affect the way a11y checks are performed as well as the way it interacts with shadow DOM.
(Assignee)

Comment 1

3 years ago
Created attachment 8660899 [details] [review]
Github pull request.
Attachment #8660899 - Flags: review?(wilsonpage)
Comment on attachment 8660899 [details] [review]
Github pull request.

Seems good overall, glad someone is taking care of this :) I have a few questions/nits before we land.

- I'm not familiar with Marionette. What new features does this patch is make use of?
- I'd prefer to test names to actually describe the functionality they are testing.
Attachment #8660899 - Flags: review?(wilsonpage)
(Assignee)

Comment 3

3 years ago
Comment on attachment 8660899 [details] [review]
Github pull request.

(In reply to Wilson Page [:wilsonpage] from comment #2)
> Comment on attachment 8660899 [details] [review]
> Github pull request.
> 
> Seems good overall, glad someone is taking care of this :) I have a few
> questions/nits before we land.
> 
> - I'm not familiar with Marionette. What new features does this patch is
> make use of?

There are additional a11y checks that are performed for elements such as:
* elements being focusable
* elements being inaccessible when pointer-events is set to none
* other state checks such as elements being selected
* also this version of marionette-client supports shadow DOM now.

> - I'd prefer to test names to actually describe the functionality they are
> testing.

Done.
Attachment #8660899 - Flags: review?(wilsonpage)
Comment on attachment 8660899 [details] [review]
Github pull request.

I have an outstanding question on PR. Aide from this, looks smashing! :)
Attachment #8660899 - Flags: review?(wilsonpage) → review+
(Assignee)

Comment 5

3 years ago
https://github.com/gaia-components/gaia-switch/commit/df81525990773e53ec00f6310e68c332c806558d
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

3 years ago
Reopening to add a follow up PR
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 7

3 years ago
Created attachment 8661804 [details] [review]
Follow-up Github pull request.

This is a follow up with test removal and test renaming.
Attachment #8661804 - Flags: review?(wilsonpage)
Comment on attachment 8661804 [details] [review]
Follow-up Github pull request.

:D
Attachment #8661804 - Flags: review?(wilsonpage) → review+
(Assignee)

Comment 9

3 years ago
https://github.com/gaia-components/gaia-switch/commit/b83747814c66d28c66c107a847a4d7a52ee65ef9
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.