1204719 - Don't create interfaces.manifest files from the build backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

For various reasons, it would be better not to have anything in dist/bin after running configure. interfaces.manifest are the only such thing.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Don't create interfaces.manifest files from the build backend

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8661023 [details] [diff] [review]
Don't create interfaces.manifest files from the build backend

Review of attachment 8661023 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/xpidl/Makefile.in
@@ +61,5 @@
>  
>  chrome_manifests := @chrome_manifests@
>  
> +%/interfaces.manifest: Makefile
> +	$(call py_action,buildlist,$@ $(foreach xpt,$(filter $*/%,$(registered_xpt_files)),'interfaces $(notdir $(xpt))'))

I have recollections of buildlist being slow. Fortunately we're not updating the same manifest so we don't have lock contention. (I think that was the issue before.) But I wouldn't be surprised if this slowed down the build a little. But, if this is needed for other work you are doing, so be it.

Comment 3

[Mike Hommey [:glandium]]

We're talking about a total of 3 independent .manifest files here.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9a34f5c4aae7

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a34f5c4aae7