Closed
Bug 1204719
Opened 7 years ago
Closed 7 years ago
Don't create interfaces.manifest files from the build backend
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox43 fixed)
RESOLVED
FIXED
mozilla43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(1 file)
6.26 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
For various reasons, it would be better not to have anything in dist/bin after running configure. interfaces.manifest are the only such thing.
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8661023 -
Flags: review?(gps)
Comment 2•7 years ago
|
||
Comment on attachment 8661023 [details] [diff] [review] Don't create interfaces.manifest files from the build backend Review of attachment 8661023 [details] [diff] [review]: ----------------------------------------------------------------- ::: config/makefiles/xpidl/Makefile.in @@ +61,5 @@ > > chrome_manifests := @chrome_manifests@ > > +%/interfaces.manifest: Makefile > + $(call py_action,buildlist,$@ $(foreach xpt,$(filter $*/%,$(registered_xpt_files)),'interfaces $(notdir $(xpt))')) I have recollections of buildlist being slow. Fortunately we're not updating the same manifest so we don't have lock contention. (I think that was the issue before.) But I wouldn't be surprised if this slowed down the build a little. But, if this is needed for other work you are doing, so be it.
Attachment #8661023 -
Flags: review?(gps) → review+
Assignee | ||
Comment 3•7 years ago
|
||
We're talking about a total of 3 independent .manifest files here.
https://hg.mozilla.org/mozilla-central/rev/9a34f5c4aae7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Updated•4 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•