1204731 - telemetry for peer h2 goaway

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Patrick McManus [:mcmanus]]

record in telemetry the status code from any recieved goaway frame (or
the lack of receipt of such a frame).

The basic idea is to have an error rate metric we can watch when
making h2 changes.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: telemetry for peer h2 goaway

Comment 2

[Patrick McManus [:mcmanus]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=858d4b55e659

Comment 3

[u408661]

Comment on attachment 8661030 [details] [diff] [review]
telemetry for peer h2 goaway

Review of attachment 8661030 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/Http2Session.h
@@ +413,5 @@
>    // A specifc reason code for the eventual GoAway frame. If set to NO_HTTP_ERROR
>    // only NO_HTTP_ERROR, PROTOCOL_ERROR, or INTERNAL_ERROR will be sent.
>    errorType            mGoAwayReason;
>  
> +  // The error code received from the peer in a goaway frame. -1 if not

The -1 here doesn't jive with the actual value used.

Comment 4

[Patrick McManus [:mcmanus]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/074f8c86cc2d32bc9960b05a19d00de3211700b7
Bug 1204731 - telemetry for peer h2 goaway r=hurley

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/074f8c86cc2d