Closed
Bug 1204731
Opened 10 years ago
Closed 10 years ago
telemetry for peer h2 goaway
Categories
(Core :: Networking: HTTP, defect)
Core
Networking: HTTP
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: mcmanus, Assigned: mcmanus)
Details
Attachments
(1 file)
|
6.98 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
record in telemetry the status code from any recieved goaway frame (or
the lack of receipt of such a frame).
The basic idea is to have an error rate metric we can watch when
making h2 changes.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8661030 -
Flags: review?(hurley)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Comment on attachment 8661030 [details] [diff] [review]
telemetry for peer h2 goaway
Review of attachment 8661030 [details] [diff] [review]:
-----------------------------------------------------------------
::: netwerk/protocol/http/Http2Session.h
@@ +413,5 @@
> // A specifc reason code for the eventual GoAway frame. If set to NO_HTTP_ERROR
> // only NO_HTTP_ERROR, PROTOCOL_ERROR, or INTERNAL_ERROR will be sent.
> errorType mGoAwayReason;
>
> + // The error code received from the peer in a goaway frame. -1 if not
The -1 here doesn't jive with the actual value used.
Attachment #8661030 -
Flags: review?(hurley) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/074f8c86cc2d32bc9960b05a19d00de3211700b7
Bug 1204731 - telemetry for peer h2 goaway r=hurley
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•