1204759 - Back port app usage metrics to TV System

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Evelyn Hung]

Since v2.2 we have app usage metric in phone build, we should also enable this on TV.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] luke-chang:tv_app_usage_metrics > mozilla-b2g:master

Comment 2

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8665254 [details] [review]
[gaia] luke-chang:tv_app_usage_metrics > mozilla-b2g:master

Hi Rex,

Would you mind taking a look at this patch? Thanks.

Comment 3

[Luke Chang [:lchang] (inactive)]

In this patch, I copied the "app_usage_metrics.js" from phone system app and only removed "SIMSlotManager" related code [1] & [2] since there's no SIM card on TV.

Also, I keep some unnecessary events such as "lockscreen-appopened", "lockscreen-appclosed", "applicationenabled" and "applicationdisabled" as-is because I prefer minimal changes and they won't break this function at all.


[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_usage_metrics.js#L682
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_usage_metrics.js#L691-L740

Comment 4

[Luke Chang [:lchang] (inactive)]

I've updated my patch for preventing "getUniqueIdentifier" from trying to get the IMEI via mozTelephony API [1].


[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/app_usage_metrics.js#L346-L355

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8665254 [details] [review]
[gaia] luke-chang:tv_app_usage_metrics > mozilla-b2g:master

Looks good to me!

Comment 6

[Josh Cheng [:josh]]

Hi Luke,
Is this one ready for check-in? Thanks!

Comment 7

[Luke Chang [:lchang] (inactive)]

Hi Josh,

The previous tests are failed on GijTV. I've restarted the tests and will land it as soon as it passes all the tests.

Comment 8

[Luke Chang [:lchang] (inactive)]

tests passed: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=18678dd4a7049afeec7c32e16c2ce2a522014324

landed on master: https://github.com/mozilla-b2g/gaia/commit/26af53f22936eb0fa4f778ab014670d36106be2f