Fix warnings in widget/gonk/libdisplay

RESOLVED FIXED in Firefox 43

Status

()

Core
Widget: Gonk
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: njn, Assigned: njn)

Tracking

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We currently have two warnings in widget/gonk/libdisplay showing up on the test
machines:

> B2G/frameworks/native/include/binder/Binder.h:33:22: error: 'virtual android::status_t android::BBinder::dump(int, const android::Vector<android::String16>&)' was hidden [-Werror=overloaded-virtual]
> gecko/widget/gonk/libdisplay/VirtualDisplaySurface.h:87:18: error: by 'virtual void android::VirtualDisplaySurface::dump(android::String8&) const' [-Werror=overloaded-virtual]

and:

> gecko/widget/gonk/libdisplay/VirtualDisplaySurface.cpp:37:20: error: 'const char* android::dbgCompositionTypeStr(android::DisplaySurface::CompositionType)' defined but not used [-Werror=unused-function]
(Assignee)

Comment 1

3 years ago
Created attachment 8661054 [details] [diff] [review]
Fix warnings in widget/gonk/libdisplay
Attachment #8661054 - Flags: review?(mwu)

Updated

3 years ago
Attachment #8661054 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/dbac0162aeea
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.