Closed Bug 1204772 Opened 4 years ago Closed 4 years ago

Fix warnings in widget/gonk/libdisplay

Categories

(Core Graveyard :: Widget: Gonk, defect)

defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

We currently have two warnings in widget/gonk/libdisplay showing up on the test
machines:

> B2G/frameworks/native/include/binder/Binder.h:33:22: error: 'virtual android::status_t android::BBinder::dump(int, const android::Vector<android::String16>&)' was hidden [-Werror=overloaded-virtual]
> gecko/widget/gonk/libdisplay/VirtualDisplaySurface.h:87:18: error: by 'virtual void android::VirtualDisplaySurface::dump(android::String8&) const' [-Werror=overloaded-virtual]

and:

> gecko/widget/gonk/libdisplay/VirtualDisplaySurface.cpp:37:20: error: 'const char* android::dbgCompositionTypeStr(android::DisplaySurface::CompositionType)' defined but not used [-Werror=unused-function]
Attachment #8661054 - Flags: review?(mwu) → review+
https://hg.mozilla.org/mozilla-central/rev/dbac0162aeea
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.