1204801 - Move Bluetooth Setup module into separate file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

BluetoothDaemonInterface.cpp contains a mixture of different IPC modules (setup, core) and the overall protocol handling. The modules should be into their own files to make the source code more readable.

This bug report is about moving the Setup module into its own source file.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1204801: Move |BluetoothDaemonSetupModule| into separate compilation unit

No code changes here, just moving code around.

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1204801: Move |BlutoothSetupResultHandler| to generic backend interface

Again no code changes.

Comment 3

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [039 Bug 1204801: Use enum constants for Bluetooth Service module

Comment 4

[Ben Tian (inactive)]

Comment on attachment 8661124 [details] [diff] [review]
[039 Bug 1204801: Use enum constants for Bluetooth Service module

Review of attachment 8661124 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Ben Tian (inactive)]

Comment on attachment 8661123 [details] [diff] [review]
[02] Bug 1204801: Move |BlutoothSetupResultHandler| to generic backend interface

Review of attachment 8661123 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 6

[Ben Tian (inactive)]

Comment on attachment 8661122 [details] [diff] [review]
[01] Bug 1204801: Move |BluetoothDaemonSetupModule| into separate compilation unit

Review of attachment 8661122 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/f46e4ced44d3
https://hg.mozilla.org/integration/b2g-inbound/rev/431b83a1923a
https://hg.mozilla.org/integration/b2g-inbound/rev/d0f2e3af0595

Comment 8

[Thomas Zimmermann [:tzimmermann] [:tdz]]

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=d0f2e3af0595

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f46e4ced44d3
https://hg.mozilla.org/mozilla-central/rev/431b83a1923a
https://hg.mozilla.org/mozilla-central/rev/d0f2e3af0595