Move Bluetooth Setup module into separate file

RESOLVED FIXED in Firefox 43

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: tzimmermann, Assigned: tzimmermann)

Tracking

unspecified
FxOS-S7 (18Sep)
All
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(3 attachments)

BluetoothDaemonInterface.cpp contains a mixture of different IPC modules (setup, core) and the overall protocol handling. The modules should be into their own files to make the source code more readable.

This bug report is about moving the Setup module into its own source file.
Depends on: 1203092
No code changes here, just moving code around.
Attachment #8661122 - Flags: review?(btian)
Comment on attachment 8661124 [details] [diff] [review]
[039 Bug 1204801: Use enum constants for Bluetooth Service module

Review of attachment 8661124 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661124 - Flags: review?(btian) → review+
Comment on attachment 8661123 [details] [diff] [review]
[02] Bug 1204801: Move |BlutoothSetupResultHandler| to generic backend interface

Review of attachment 8661123 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661123 - Flags: review?(btian) → review+
Comment on attachment 8661122 [details] [diff] [review]
[01] Bug 1204801: Move |BluetoothDaemonSetupModule| into separate compilation unit

Review of attachment 8661122 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661122 - Flags: review?(btian) → review+
https://hg.mozilla.org/mozilla-central/rev/f46e4ced44d3
https://hg.mozilla.org/mozilla-central/rev/431b83a1923a
https://hg.mozilla.org/mozilla-central/rev/d0f2e3af0595
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.