Closed Bug 1204801 Opened 6 years ago Closed 6 years ago

Move Bluetooth Setup module into separate file

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(firefox43 fixed)

RESOLVED FIXED
FxOS-S7 (18Sep)
Tracking Status
firefox43 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(3 files)

BluetoothDaemonInterface.cpp contains a mixture of different IPC modules (setup, core) and the overall protocol handling. The modules should be into their own files to make the source code more readable.

This bug report is about moving the Setup module into its own source file.
Depends on: 1203092
No code changes here, just moving code around.
Attachment #8661122 - Flags: review?(btian)
Comment on attachment 8661124 [details] [diff] [review]
[039 Bug 1204801: Use enum constants for Bluetooth Service module

Review of attachment 8661124 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661124 - Flags: review?(btian) → review+
Comment on attachment 8661123 [details] [diff] [review]
[02] Bug 1204801: Move |BlutoothSetupResultHandler| to generic backend interface

Review of attachment 8661123 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661123 - Flags: review?(btian) → review+
Comment on attachment 8661122 [details] [diff] [review]
[01] Bug 1204801: Move |BluetoothDaemonSetupModule| into separate compilation unit

Review of attachment 8661122 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661122 - Flags: review?(btian) → review+
You need to log in before you can comment on or make changes to this bug.