1204806 - [TV 2.6] Draw cursor while virtual mouse is connected to TV

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

We need to draw mouse cursor while hardware mouse or virtual mouse is connected to TV. HwComposer supports HWC_CURSOR_OVERLAY for drawing mouse cursor [1].

In the past APC project we drew mouse cursor in shell.html (see bug 937464) and it hurt the rendering performance due to constantly reflow. We should avoid this kind of approach on TV project.

@cjones also tried to render mouse cursor in Gecko for RPi on bug 1082892.

[1] http://androidxref.com/5.1.1_r6/xref/hardware/libhardware/include/hardware/hwcomposer.h#787

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

On Gonk platform we already have a SpriteController to draw cursor/finger for mouse/touch input and the position can be controlled by PointerController::move. We only need to create a call path from EventShuttle to PointerController.

Comment 2

[Eric Tsai (no more review request accepted)]

Use this bug to implement cursor integration with bug 1270701. While it's in cursor mode and any client connects, show cursor; otherwise, hide cursor?

Comment 3

[Eric Tsai (no more review request accepted)]

Attachment: Patch 1. Draw mouse cursor when remote user connected in cursor mode

Comment 4

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8758641 [details] [review]
Patch 1. Draw mouse cursor when remote user connected in cursor mode

Let's check the conversations on github.

Comment 5

[Eric Tsai (no more review request accepted)]

Comment on attachment 8758641 [details] [review]
Patch 1. Draw mouse cursor when remote user connected in cursor mode

Hi Kilik, based on conversation on PR, please help to review this patch.

Comment 6

[Kilik Kuo [:kikuo] (inactive)]

Comment on attachment 8758641 [details] [review]
Patch 1. Draw mouse cursor when remote user connected in cursor mode

Please file a follow-up to remove these cursor-related interfaces,variables out of nsIWidget.h to a separated utility instance. It could be used from namespace DOM. The implementation in that instance may be like [1],[2]. By transferring values through function signatures and posting Invalidate/ScheduleRender via a thread. That should be work.

Thanks.

[1] https://dxr.mozilla.org/mozilla-central/source/widget/windows/WinUtils.h
[2] https://dxr.mozilla.org/mozilla-central/source/widget/SharedWidgetUtils.cpp

Comment 7

[Eric Tsai (no more review request accepted)]

Comment on attachment 8758641 [details] [review]
Patch 1. Draw mouse cursor when remote user connected in cursor mode

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 1204806
User impact if declined: No mouse cursor when using remote control virtual touch pad
Testing completed: self-tested
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: N/A

Comment 8

[Eric Tsai (no more review request accepted)]

Follow-up bug: 1277779

Comment 9

[Josh Cheng [:josh]]

Comment on attachment 8758641 [details] [review]
Patch 1. Draw mouse cursor when remote user connected in cursor mode

Approve for TV 2.5

Comment 10

[Eric Tsai (no more review request accepted)]

Hi Gary, please help to merge for TV 2.6, thanks.

Comment 11

[Gary Chen [:xeonchen]]

https://github.com/mozilla-b2g/gecko-b2g/commit/d20c9868a631f4a3901d535bd65daadcb55736ec