1204808 - Move DevTools prefs to their own new file

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Since DevTools will soon have its own /devtools directory, it makes sense to pull the prefs out of browser and toolkit and into our own files.

Comment 1

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9155a05a1d44

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: patch v1

Comment 3

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ae499a85db6

Comment 4

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5fd0d8887f1

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

Rebased, that's the kind of patch to land quickly as it will bitrot
anytime someone tweaks any devtools pref!

The last try looks promising.

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

Who else do you think I should flag for review regarding browser / moz.build changes?

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8672640 [details] [diff] [review]
patch v2

Review of attachment 8672640 [details] [diff] [review]:
-----------------------------------------------------------------

I suppose you could ask :glandium for review, but the changes mostly seem "obvious" to me...  Maybe we don't need additional review?

::: browser/installer/package-manifest.in
@@ +687,5 @@
>  
>  ; DevTools
>  @RESPATH@/browser/chrome/devtools@JAREXT@
>  @RESPATH@/browser/chrome/devtools.manifest
> +@RESPATH@/browser/defaults/preferences/preferences.js

Since our prefs file gets packaged in directory with other prefs files, it seems like `devtools.js` would be a much better name.

Also, other pref files in here use the format:

  @RESPATH@/browser/@PREF_DIR@/<FILE>

::: devtools/client/moz.build
@@ +51,5 @@
>  
>  JAR_MANIFESTS += ['jar.mn']
>  
> +JS_PREFERENCE_FILES += [
> +    'preferences.js',

Assuming you rename it to something DevTools specific, maybe we should move the file under a prefs directory?  That way a file like `devtools.js` is not misinterpreted to be some main JS module.

Comment 8

[Alexandre Poirot [:ochameau]]

Attachment: patch v3

Renamed to devtools and use @PREF_DIR@.

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8672679 [details] [diff] [review]
patch v3

Review of attachment 8672679 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like you forgot to add the moz.build file in preferences to your patch.

Comment 10

[Alexandre Poirot [:ochameau]]

Attachment: patch v4

With the moz.build...

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8673119 [details] [diff] [review]
patch v4

Review of attachment 8673119 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for working on this!

Comment 12

[Alexandre Poirot [:ochameau]]

https://hg.mozilla.org/integration/fx-team/rev/2801520e5965ec09e8b31fa1954a0699fa1a7aa8
Bug 1204808 - Move devtools prefs to its own file in /devtools folder. r=jryans

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2801520e5965