1204817 - [Telephony][CDMA] Cannot hang up a conference call (3-way call)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Ben Hsu [:HoPang]]

It's a regression found recently. When we hang up a CDMA conference call, the remote parties will be hung up as expected, but we missed the call state change event on local end.

Comment 1

[Ben Hsu [:HoPang]]

Attachment: Delete the child property of a parent call only when the parent call exists

The root cause is a parent call is deleted before its child call being deleted. Here is a more wordy explaination, when there are disconnected calls, we will delete the calls from TelephonyService and their parent call one by one. However, if a parent call is deleted before its child call, we'll get an JavaScript error and fail to remove the child from its parent.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

I think this regression is created by bug 1155063.

In bug 1155063, _handleCallDisconnected() is handled recursively if the disconnected call is a parentCall, so the childCall will always be clean up before the parent call.
https://hg.mozilla.org/mozilla-central/file/b77f028dce5d/dom/telephony/gonk/TelephonyService.js#l1393

After bug 1155063, the parent call is always clean up 1st.

It's a good habit to figure out the root cause when providing the fix to prevent creating another regression. :)

Comment 3

[Ben Hsu [:HoPang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9941a9fb948f&exclusion_profile=false

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/40236e4d9d64

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/40236e4d9d64