Closed Bug 1204822 Opened 6 years ago Closed 6 years ago

No such file libgtk-3.so.0 in Hazard build

Categories

(Testing :: General, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: jdai, Assigned: jdai)

References

Details

Attachments

(1 file, 3 obsolete files)

According to bug 1146713 comment 150, B2G Desktop Linux x64 Hazard Analysis Build fail and got  /bin/bash: /builds/slave/b2g_b2g-in_l64-b2g-haz_dep-000/build/gaia/b2g_sdk/43.0a1-2015-08-17-15-02-06/b2g/xpcshell: No such file or directory
See Also: → 1203513
Moving set LD_LIBRARY_PATH value code to buildbase.py. B2G Desktop Linux x64 Hazard Analysis Build success.

Try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=9fa12bbac4eb

Hi Dustin, 
May I have your review? Thanks.
Attachment #8661152 - Flags: review?(dustin)
Comment on attachment 8661152 [details] [diff] [review]
Add LD_LIBRARY_PATH in build script.

This looks good, but because it's in buildbase I'm worried it will affect other builds, so I've flagged Jordan for a second review.
Attachment #8661152 - Flags: review?(jlund)
Attachment #8661152 - Flags: review?(dustin)
Attachment #8661152 - Flags: review+
Comment on attachment 8661152 [details] [diff] [review]
Add LD_LIBRARY_PATH in build script.

Cancel the review first. I want to check Bug 1204800 will pass build also.
Attachment #8661152 - Flags: review?(jlund)
Verified on all builds, they are all green.

Try link:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fcbd2f2489a
Attachment #8661152 - Attachment is obsolete: true
Attachment #8662198 - Flags: review?(jlund)
Attachment #8662198 - Flags: review?(dustin)
Attachment #8662198 - Flags: review?(dustin) → review+
Comment on attachment 8662198 [details] [diff] [review]
Add LD_LIBRARY_PATH in build script. v2

Review of attachment 8662198 [details] [diff] [review]:
-----------------------------------------------------------------

should be harmless. only b2g device and hazard use B2GBuildBaseScript which I guess is the hazard motivation for putting the libgtk-3 logic there.
Attachment #8662198 - Flags: review?(jlund) → review+
Attachment #8662198 - Attachment is obsolete: true
Attachment #8662743 - Flags: review+
Keywords: checkin-needed
This has caused an interesting issue (see bug 1207009 for actual failure). 

cmd = ["ln", "-s", gtk3_path, gtk3_symlink_path]

This line causes a fatal error that causes the build to be reported as a failure when the symblink exists. The build will succeed once on all slaves and from the second time, it will throw an error like so

17:58:43     INFO - Running main action method: build_symbols
17:58:43     INFO - Running command: ['ln', '-s', '/builds/slave/b2g_m-in_emu_dep-0000000000000/build/gtk3', '/builds/slave/b2g_m-in_emu_dep-0000000000000/build/gecko/gtk3']
17:58:43     INFO - Copy/paste: ln -s /builds/slave/b2g_m-in_emu_dep-0000000000000/build/gtk3 /builds/slave/b2g_m-in_emu_dep-0000000000000/build/gecko/gtk3
17:58:43     INFO -  ln: creating symbolic link `/builds/slave/b2g_m-in_emu_dep-0000000000000/build/gecko/gtk3/gtk3': File exists
17:58:43    ERROR - Return code: 1
17:58:43    ERROR - failed to create symlink

We should probably force the symlinking or fail gracefully if the link already exists. For now, I'm backing this out so that B2G ICS builds turn green again.
Flags: needinfo?(jdai)
Flags: needinfo?(jdai)
Use the symlinking if the link not exists.

Try link:
https://treeherder.allizom.org/#/jobs?repo=try&revision=60bd5048e3ab
Attachment #8662743 - Attachment is obsolete: true
Attachment #8664610 - Flags: review+
Keywords: checkin-needed
Tests were still broken on the backout, so this likely wasn't at fault. I'll reland it later today once I sort out what did break it.
Flags: needinfo?(wkocher)
https://hg.mozilla.org/mozilla-central/rev/74ec968ef9c5
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.