[Metrics] Address pref="" issue with user-timing events -- (from bug 1198517)

RESOLVED FIXED in Firefox 43

Status

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: rnicoletti, Assigned: rnicoletti)

Tracking

unspecified
FxOS-S8 (02Oct)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 years ago
Address the issue mentioned here: https://bugzilla.mozilla.org/show_bug.cgi?id=1198517#c16, where user may set the pref to "" in order to disable tracking of user-timing event metrics.
Assignee

Updated

4 years ago
Assignee

Comment 1

4 years ago
Jan, thanks for being very polite about that code that should not have been there. I'm not sure what I was thinking when I wrote that. In any event, all use cases are working (no pref, valid pref, pref set to ""), now that I'm letting `SettingsListener.observe` do its job.
Attachment #8662073 - Flags: review?(janx)
Comment on attachment 8662073 [details] [diff] [review]
bug-1204938.patch

Review of attachment 8662073 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, thank you for following up so quickly!
Attachment #8662073 - Flags: review?(janx) → review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/15859b18d22e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in before you can comment on or make changes to this bug.