1204985 - fix mach SharedMemory to build for iOS

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[(not currently active) Ted Mielczarek]

bug 1161166 changed Darwin to use stuff that doesn't build on iOS. It's possible we could make it work, but for now I just want to switch back to the POSIX shmem.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

What doesn't work on iOS?

Comment 2

[(not currently active) Ted Mielczarek]

I can't remember offhand, I will try building with it tomorrow to see.

Comment 3

[(not currently active) Ted Mielczarek]

OK, so, in my local tree I pulled a newer mach_ipc_mac.h from upstream Chromium, and that #includes Foundation.h:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/gecko-ios/file/default/ipc/chromium/src/chrome/common/mach_ipc_mac.h#l16

...which is ObjC code, so it fails because we wind up including it in regular C++ files.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

So the right fix is to not leak the ObjC stuff out into C++. That sounds at least tractable.

Comment 5

[(not currently active) Ted Mielczarek]

So if I renamed that .cpp file to .mm, I get to the root problem:
 0:10.10 /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS8.4.sdk/usr/include/mach/mach_vm.h:1:2: error: mach_vm.h unsupported.

Comment 6

[(not currently active) Ted Mielczarek]

Breakpad has workarounds for this:
https://chromium.googlesource.com/breakpad/breakpad/+/master/src/client/mac/handler/mach_vm_compat.h#35

Comment 7

[(not currently active) Ted Mielczarek]

Attachment: MozReview Request: bug 1204985 - make SharedMemoryBasic_mach build on iOS. r?billm

bug 1204985 - make SharedMemoryBasic_mach build on iOS. r?billm

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8664381 [details]
MozReview Request: bug 1204985 - make SharedMemoryBasic_mach build on iOS. r?billm

https://reviewboard.mozilla.org/r/19947/#review17985

Comment 9

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb291e7e0193

Comment 10

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b16238102bba

Comment 11

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/edf2e825c10d245ae7d45e2e1f554b3271cc1f31
bug 1204985 - make SharedMemoryBasic_mach build on iOS. r=billm

Comment 12

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/febb7ebc1644ba8b3f670c4d414f23aef6d154d3
bug 1204985 horrible clobber-avoidance bustage fix r=YOLO CLOSED TREE

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/edf2e825c10d
https://hg.mozilla.org/mozilla-central/rev/febb7ebc1644