1205020 - Internal compiler error in TestTuple.cpp, MSVC12

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Excerpt from log, reproduced it twice now:

49:03.59 sync_dispatcher.obj
49:03.87 TestTuple.cpp
49:03.88 c:\fx\obj-i686-pc-mingw32\dist\include\mozilla/Tuple.h(56) : fatal error C1001: An internal error has occurred in the compiler.
49:03.90 (compiler file 'msc1.cpp', line 1325)
49:03.93  To work around this problem, try simplifying or changing the program near the locations listed above.
49:03.94 Please choose the Technical Support command on the Visual C++
49:03.95  Help menu, or open the Technical Support help file for more information
49:03.95 Internal Compiler Error in c:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\BIN\cl.exe.  You will be prompted to send an error report to Microsoft later.
49:03.95 INTERNAL COMPILER ERROR in 'c:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\BIN\cl.exe'
49:03.95     Please choose the Technical Support command on the Visual C++
49:03.95     Help menu, or open the Technical Support help file for more information
49:03.96
49:03.96 In the directory  /c/fx/obj-i686-pc-mingw32/mfbt/tests
49:03.96 The following command failed to execute properly:
49:03.96 c:/fx/obj-i686-pc-mingw32/_virtualenv/Scripts/python.exe -m mozbuild.action.cl cl -FoTestTuple.obj -c -DIMPL_MFBT -DAB_CD=en-US -DNO_NSPR_10_SUPPORT -Ic:/fx/mfbt/tests -I. -I../../dist/include -I../../dist/include/testing -Ic:/fx/obj-i686-pc-mingw32/dist/include/nspr -Ic:/fx/obj-i686-pc-mingw32/dist/include/nss -MD -FI ../../dist/include/mozilla-config.h -DMOZILLA_CLIENT -TP -nologo -D_HAS_EXCEPTIONS=0 -W3 -Gy -arch:IA32 -FS -wd4251 -wd4244 -wd4267 -wd4345 -wd4351 -wd4482 -wd4800 -wd4819 -we4553 -GR- -DNDEBUG -DTRIMMED -Zi -UDEBUG -DNDEBUG -O1 -Oi -Oy -wd4275 -wd4530 -FdTestTuple.pdb
c:/fx/mfbt/tests/TestTuple.cpp
49:03.96 c:/fx/config/rules.mk:958: recipe for target 'TestTuple.obj' failed
49:03.96 mozmake.EXE[5]: *** [TestTuple.obj] Error 1
49:03.97 c:/fx/config/recurse.mk:71: recipe for target 'mfbt/tests/target' failed
49:03.97 mozmake.EXE[4]: *** [mfbt/tests/target] Error 2
49:03.97 mozmake.EXE[4]: *** Waiting for unfinished jobs....
49:03.97 gfxGDIFont.obj
49:03.98 math.cc
49:04.04 vorg.obj
49:04.46 sidestep_resolver.cc
49:04.51 sync_interception.obj

HG changeset f76ad9b2ec28 from fx-team repository as tip.

Comment 1

[(Away)]

This is unfortunate :-(

Presumably it doesn't happen on all VS2013 builds, or else the tree would be closed by now.

Perhaps it's only on Windows 10? Do other Win10 developers reproduce it?

Does #pragma optimize("", off) in TestTuple.cpp fix it?

Comment 2

[(Away)]

And, are you on the latest VS2013 update? (Update 4 I think)

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I'm running:
Microsoft Visual Studio Express 2013 for Windows Desktop
Version 12.0.31101.00 Update 4
Microsoft .NET Framework
Version 4.6.00079

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

#pragma optimize("", off) does fix it for me.

Comment 5

[Nathan Froyd [:froydnj]]

Comment on attachment 8665011 [details] [diff] [review]
Patch

Review of attachment 8665011 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the changes below.

::: mfbt/tests/TestTuple.cpp
@@ +26,5 @@
>  using mozilla::UniquePtr;
>  using mozilla::unused;
>  using std::pair;
>  
> +#pragma optimize("", off)

This needs a comment, referencing the busted MSVC version and preferably pointing back at this bug.

Also, you may need to surround this with an #ifdef _MSC_VER so we don't get warnings about unknown pragmas from other compilers.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/cafa078ece95

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/cafa078ece95