Review details page file should display correct file status

VERIFIED FIXED in 44.1

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: TheOne, Assigned: TheOne)

Tracking

unspecified
44.1

Details

(Whiteboard: [ReviewTeam])

(Assignee)

Description

3 years ago
On the review details page, in the section "Files in this version" the file status is displayed. This file status is wrong sometimes, for example for already preliminary reviewed versions, it still says "ending Preliminary Review".

The bug is in apps/editors/helpers.py :: file_review_status() which does not handle all cases correctly.
(Assignee)

Updated

3 years ago
Whiteboard: [ReviewTeam]
(Assignee)

Updated

3 years ago
QA Contact: awagner
(Assignee)

Updated

3 years ago
Assignee: nobody → awagner
QA Contact: awagner

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/97a575349d13683226579424495dd86b6f487678
Show correct file status on review page (bug 1205039)

https://github.com/mozilla/olympia/commit/2f0d2f44b8da123c4998e5ee0020bef3dfb76d2f
Merge pull request #749 from wagnerand/bug1205039

Show correct file status on review page (bug 1205039)
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 44.1

Comment 3

3 years ago
Verified as fixed on AMO-dev FF41(Win 7).
Postfix screenshot: http://screencast.com/t/1qf316udur
Closing bug.
Status: RESOLVED → VERIFIED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.