Closed
Bug 1205039
Opened 10 years ago
Closed 10 years ago
Review details page file should display correct file status
Categories
(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)
addons.mozilla.org Graveyard
Admin/Editor Tools
Tracking
(Not tracked)
VERIFIED
FIXED
44.1
People
(Reporter: TheOne, Assigned: TheOne)
Details
(Whiteboard: [ReviewTeam])
On the review details page, in the section "Files in this version" the file status is displayed. This file status is wrong sometimes, for example for already preliminary reviewed versions, it still says "ending Preliminary Review".
The bug is in apps/editors/helpers.py :: file_review_status() which does not handle all cases correctly.
|
Assignee | |
Updated•10 years ago
|
Whiteboard: [ReviewTeam]
|
|
Assignee | |
Updated•10 years ago
|
QA Contact: awagner
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → awagner
QA Contact: awagner
|
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/olympia
https://github.com/mozilla/olympia/commit/97a575349d13683226579424495dd86b6f487678
Show correct file status on review page (bug 1205039)
https://github.com/mozilla/olympia/commit/2f0d2f44b8da123c4998e5ee0020bef3dfb76d2f
Merge pull request #749 from wagnerand/bug1205039
Show correct file status on review page (bug 1205039)
|
||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 44.1
|
||
Comment 3•10 years ago
|
||
Verified as fixed on AMO-dev FF41(Win 7).
Postfix screenshot: http://screencast.com/t/1qf316udur
Closing bug.
Status: RESOLVED → VERIFIED
|
||
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•