1205040 - [Settings] Add default setting for Tracking Protection

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Tiffanie Shakespeare [:tif]]

A new item needs to be added to Settings to enable the user to change their default Tracking Protection Setting.

Please see UX specs listed in the Meta Bug.

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

[Blocking Requested - why for this release]:

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Note, this bug will be used to track the additional toggle for Tracking Protection in the Browser Privacy panel. First we will need bug 1210740 to be able to control this from settings.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

Flagging Yura to review the Settings app changes.

Flagging Kevin for adding a link to gaia_switch.

Flagging Eric to see that the Learn More link looks okay, and redirects to the right place.

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

The settings part looks fine, however you have a failing unit test.
Also it looks like switch styling regresses with this patch. I noticed styling issues in wi-di panel, were description is misplaced and sometimes the switch is cut-off from the bottom

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

s/wi-di/wi-fi

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

(In reply to Yura Zenevich [:yzen] from comment #5)
> The settings part looks fine, however you have a failing unit test.
> Also it looks like switch styling regresses with this patch. I noticed
> styling issues in wi-di panel, were description is misplaced and sometimes
> the switch is cut-off from the bottom

Ahh good catch! I'll fix these up before reflagging you.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

Alright, addressed Yura and Kevin's comments and fixed the test (also added a test). This is ready for the next round.

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

Settings part looks good to me.

Comment 10

[Tiffanie Shakespeare [:tif]]

It looks like you're linking to the Firefox desktop Tracking Protection sumo page. I know FxOS doesn't have a specific TP page yet (that's bug 1210155). 

Should we instead link it to the general security/privacy page for FxOS:
https://support.mozilla.org/en-US/products/firefox-os/privacy-and-security

And then open a new bug to update the link when the support page is ready?

Comment 11

[Michael Henretty [:mikehenrty][:mhenretty]]

(In reply to Tiffanie Shakespeare [:tif] UX from comment #10)
> It looks like you're linking to the Firefox desktop Tracking Protection sumo
> page. I know FxOS doesn't have a specific TP page yet (that's bug 1210155). 
> 
> Should we instead link it to the general security/privacy page for FxOS:
> https://support.mozilla.org/en-US/products/firefox-os/privacy-and-security
> 
> And then open a new bug to update the link when the support page is ready?

Works for me, I updated the link to: https://support.mozilla.org/products/firefox-os/privacy-and-security

Comment 12

[Eric Pang [:epang] UX]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

Thanks Michael!  Note that we've updated the 'Learn More' link styling to be consistent with other parts of the OS (see DNT and 'Improve Foxfood').

Looks like Tif has already commented on the link :)

Comment 13

[Tiffanie Shakespeare [:tif]]

Created bug 1211953 to update the link when the sumo page is ready.

Comment 14

[Tiffanie Shakespeare [:tif]]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

Looks good!

Comment 15

[Kevin Grandon :kgrandon]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

This looks good, but I _really_ don't think we should add the link to the content insertion in the component. My reasoning is that I don't think we should be making one-off component changes, and that it would be better to wait for a second consumer of that insertion point. At that point it should be fairly simple to abstract.

I left an example on github that I think should work with a few small styling changes, please let me know what you think.

Comment 16

[Michael Henretty [:mikehenrty][:mhenretty]]

Bug 1211738 gave us a second consumer for the link. I updated the PR to make the Private Browsing toggle also use the gaia-switch link feature. We will have a 3rd consumer soon when we implement the full privacy control panel spec which adds a TP toggle to the browser chrome doorhanger which has a "Learn More" link in it.

Comment 17

[Kevin Grandon :kgrandon]

Comment on attachment 8669671 [details] [review]
[gaia] mikehenrty:bug-1205040-tracking-protection-setting > mozilla-b2g:master

Looks good then in that case. Thanks!

Comment 18

[Michael Henretty [:mikehenrty][:mhenretty]]

master: https://github.com/mozilla-b2g/gaia/commit/981ef5bc38d162ed2e30b27afb46db195ddc3f4a