Closed
Bug 1205072
Opened 9 years ago
Closed 8 years ago
Markdown should not call quoteUrl() for code sections
Categories
(Bugzilla :: Creating/Changing Bugs, defect)
Bugzilla
Creating/Changing Bugs
Tracking
()
RESOLVED
FIXED
Bugzilla 6.0
People
(Reporter: altlist, Assigned: altlist)
References
Details
Attachments
(1 file, 2 obsolete files)
|
3.10 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
If I have a comment text below:
```
See bug NNN
```
Markdown will expand "bug NNN" to the anchor text, then escape it to look like below
See <a href=".....">bug NNN</a>
On the one hand, I think code blocks should expand ticket ids. On the other hand, it breaks the intent of code blocks, plus could make syntax highlighting a challenge (bug 1203960).
This is with my custom Bugzilla 5.0 code based
|
Assignee | |
Comment 1•9 years ago
|
||
Attached is a suggestion, where I removed all fenced code blocks from the start, as opposed to doing this inline inside various sections.
Attachment #8662012 -
Flags: review?(gerv)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Turns out indented code blocks exhibit the same issue, such that seems best to handle all CodeBlocks within Bugzilla. I've updated a working patch although there must be a better way to handle this
Attachment #8662012 -
Attachment is obsolete: true
Attachment #8662012 -
Flags: review?(gerv)
Attachment #8662610 -
Flags: review?(gerv)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8662610 [details] [diff] [review] v2 Koosha: you wrote the Markdown support. Can you look at this patch also? :-) Thanks, Gerv
Attachment #8662610 -
Flags: review?(gerv) → review?(koosha.khajeh)
|
|
Assignee | |
Comment 4•9 years ago
|
||
Updated patch to reflect changes done in ticket 1214310. This also uses private code points
Attachment #8662610 -
Attachment is obsolete: true
Attachment #8662610 -
Flags: review?(koosha.khajeh)
Attachment #8679303 -
Flags: review?(dylan)
|
||
Updated•9 years ago
|
Assignee: create-and-change → altlist
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 6.0
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8679303 [details] [diff] [review] v3 Looks good, and correctly fixes the problem. r=LpSolit
Attachment #8679303 -
Flags: review?(dylan) → review+
|
|
||
Comment 6•8 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git a6562e0..c9ba7ae master -> master
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Summary: Markdown incorrectly calls quoteUrl for coded sections → Markdown should not call quoteUrl() for code sections
You need to log in
before you can comment on or make changes to this bug.
Description
•