Closed
Bug 1205117
Opened 10 years ago
Closed 10 years ago
Button to exit full screen mode doesn't fit longer translations
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
RESOLVED
DUPLICATE
of bug 1209060
People
(Reporter: striptm, Unassigned)
References
Details
(Whiteboard: [transvision-feedback])
Attachments
(2 files)
The string:
Exit Full Screen
Is translated as:
Salir de pantalla completa
And:
Overflow the buttom width (no right margin).
This is the XUL code (can help to css applied style)
<hbox xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="fullscreen-warning" class="undefined" style="" onscreen="true"><description id="fullscreen-domain-text">
<label id="fullscreen-domain" value="youtube.com"/>
está ahora en pantalla completa
</description><description id="fullscreen-generic-text">
Este documento está ahora en pantalla completa
</description><button id="fullscreen-exit-button" label="Salir de pantalla completa (Esc)" oncommand="FullScreen.exitDomFullScreen();"/></hbox>
Feedback via Transvision:
https://transvision.mozfr.org/?sourcelocale=en-US&locale=es-ES&repo=aurora&search_type=entities&recherche=toolkit/chrome/global/videocontrols.dtd:fullscreenButton.exitfullscreenlabel
Comment 1•10 years ago
|
||
Humm... This overflows slightly because Willyaranda told me about it and I shortened the string some days ago, but I can't see how could I make it shorter. As you can see in Transvision, the "(Esc)" final part is other string. And there is no string to set width of the button nor the panel in which it is.
| Reporter | ||
Comment 2•10 years ago
|
||
| Reporter | ||
Comment 3•10 years ago
|
||
The french translation has the same problem, the solution must be global, as giving the possibility to define the width.
Comment 4•10 years ago
|
||
Adding L10n drivers so they can weigh if this should be moved to Toolkit product.
Comment 5•10 years ago
|
||
It definitely needs to be moved to another component, but are you sure that's the right string? Which version was this bug reported from?
Because it might be this, available only in Nightly
https://transvision.mozfr.org/?sourcelocale=en-US&locale=es-ES&repo=central&search_type=entities&recherche=browser/chrome/browser/browser.dtd:exitDOMFullscreen.button
And this landed in bug 1160023 (Firefox::General).
| Reporter | ||
Comment 6•10 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #5)
> It definitely needs to be moved to another component, but are you sure
> that's the right string? Which version was this bug reported from?
Yes, It is Firefox Nightly (screenshot made in Linux).
Comment 7•10 years ago
|
||
Yes, I had already shortened it as Willyaranda told me before stripTM noticed the overflow (on the short string):
http://hg.mozilla.org/l10n-central/es-ES/rev/3f4d92c47e00
Comment 8•10 years ago
|
||
flod, adding NI for you as this bug should be moved to another component.
Flags: needinfo?(francesco.lodolo)
Comment 9•10 years ago
|
||
Let's try with Firefox General first.
Assignee: rpmdisguise-nave → nobody
Blocks: 1160023
Component: es-ES / Spanish → General
Flags: needinfo?(francesco.lodolo)
Product: Mozilla Localizations → Firefox
Summary: Translation update proposed for toolkit/chrome/global/videocontrols.dtd:fullscreenButton.exitfullscreenlabel → Button to exit full screen mode doesn't fit longer translations
Comment 10•10 years ago
|
||
It looks like a bug has been fixed in bug 1209060.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Comment 11•10 years ago
|
||
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #10)
> It looks like a bug has been fixed in bug 1209060.
>
> *** This bug has been marked as a duplicate of bug 1209060 ***
Uh, thanks. Is anyone able to reproduce this (besides on release with 42)?
| Reporter | ||
Comment 12•10 years ago
|
||
Firefox Nightly 45.0a1 (2015-11-09) es-ES are OK.
You need to log in
before you can comment on or make changes to this bug.
Description
•