1205148 - Fix warnings in rdf/datasource

Status: RESOLVED FIXED

(Core Graveyard :: RDF, defect)

Description

[Nicholas Nethercote [inactive]]

Fix warnings in rdf/datasource/

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: imported patch fix-rdf-datasource-warnings

Comment 2

[Nicholas Nethercote [inactive]]

rdf/datasource/ has one warning on Windows:

> rdf/datasource/nsFileSystemDataSource.cpp(854) : warning C4996: 'swprintf':
>    swprintf has been changed to conform with the ISO C standard, adding an
>    extra character count parameter. To use traditional Microsoft swprintf, set
>    _CRT_NON_CONFORMING_SWPRINTFS.
>    c:\tools\vs2013\vc\include\swprintf.inl(85) : see declaration of 'swprintf'

As far as I can tell, swprintf has required the additional length argument for several versions, e.g.:
https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/common/windows/string_utils-inl.h?offset=400#52

Switching to swprintf_s() is probably a good idea, as it doesn't have a murky history like swprintf() does.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Fix warnings in rdf/datasource/

Also remove ALLOW_COMPILER_WARNINGS=True now that all warnings are gone.

Comment 4

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=803b992d96b4

Comment 5

[Nicholas Nethercote [inactive]]

Thank you for the review.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b308d1901a37

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b308d1901a37