Closed Bug 1205148 Opened 7 years ago Closed 7 years ago

Fix warnings in rdf/datasource

Categories

(Core Graveyard :: RDF, defect)

defect
Not set
normal

Tracking

(firefox44 fixed)

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file, 1 obsolete file)

Fix warnings in rdf/datasource/
rdf/datasource/ has one warning on Windows:

> rdf/datasource/nsFileSystemDataSource.cpp(854) : warning C4996: 'swprintf':
>    swprintf has been changed to conform with the ISO C standard, adding an
>    extra character count parameter. To use traditional Microsoft swprintf, set
>    _CRT_NON_CONFORMING_SWPRINTFS.
>    c:\tools\vs2013\vc\include\swprintf.inl(85) : see declaration of 'swprintf'

As far as I can tell, swprintf has required the additional length argument for several versions, e.g.:
https://dxr.mozilla.org/mozilla-central/source/toolkit/crashreporter/google-breakpad/src/common/windows/string_utils-inl.h?offset=400#52

Switching to swprintf_s() is probably a good idea, as it doesn't have a murky history like swprintf() does.
Summary: imported patch fix-rdf-datasource-warnings → Fix warnings in rdf/datasource
Also remove ALLOW_COMPILER_WARNINGS=True now that all warnings are gone.
Attachment #8661578 - Flags: review?(benjamin)
Attachment #8661574 - Attachment is obsolete: true
Attachment #8661578 - Flags: review?(benjamin) → review+
Thank you for the review.
https://hg.mozilla.org/mozilla-central/rev/b308d1901a37
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.