Closed Bug 1205179 Opened 5 years ago Closed 5 years ago

AVC3 content is now rejected

Categories

(Core :: Audio/Video: Playback, defect)

43 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox42 --- fixed
firefox43 --- fixed

People

(Reporter: jya, Assigned: jya)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(1 file)

This is due to bug 1202677

It errors if an avcC atom has a size <= 7.

But an AVC3 avcC atom (which has a an empty SPS and PPS) will typically have a size of 7.

This causes all BBC streams to fail
An AVC3 stream will typically use 7 bytes avcC (due to have 0 SPS/PPS)
Attachment #8661656 - Flags: review?(gsquelart)
Assignee: nobody → jyavenard
Attachment #8661656 - Flags: review?(gsquelart) → review+
Comment on attachment 8661656 [details] [diff] [review]
[mp4] Don't reject 7 bytes long avcC atom.

Approval Request Comment
[Feature/regressing bug #]: 1202677
[User impact if declined]: AVC3 (BBC and others) won't play
[Describe test coverage new/current, TreeHerder]: local
[Risks and why]: None. This is an addendum to an earlier patch that introduced a regression
[String/UUID change made/needed]: None

It's trivial enough that I'm tempted to push it straight to aurora and central!
Attachment #8661656 - Flags: approval-mozilla-aurora?
> It's trivial enough that I'm tempted to push it straight to aurora and central!

It would be awesome if this was backported now we are on the whitelist for 41.
the fix that introduced the regression was only uplifted to aurora (42) a few days ago. 41 isn't affected
Great news, thanks.
https://hg.mozilla.org/mozilla-central/rev/95bac0001e70
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
This has regressed many MSE streams.. Can we get this in in priority?
Blocks: MSE, 1197083
Comment on attachment 8661656 [details] [diff] [review]
[mp4] Don't reject 7 bytes long avcC atom.

Important regression, taking it.
Attachment #8661656 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.