1205179 - AVC3 content is now rejected

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

This is due to bug 1202677

It errors if an avcC atom has a size <= 7.

But an AVC3 avcC atom (which has a an empty SPS and PPS) will typically have a size of 7.

This causes all BBC streams to fail

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: [mp4] Don't reject 7 bytes long avcC atom.

An AVC3 stream will typically use 7 bytes avcC (due to have 0 SPS/PPS)

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8661656 [details] [diff] [review]
[mp4] Don't reject 7 bytes long avcC atom.

Approval Request Comment
[Feature/regressing bug #]: 1202677
[User impact if declined]: AVC3 (BBC and others) won't play
[Describe test coverage new/current, TreeHerder]: local
[Risks and why]: None. This is an addendum to an earlier patch that introduced a regression
[String/UUID change made/needed]: None

It's trivial enough that I'm tempted to push it straight to aurora and central!

Comment 3

[u514836]

> It's trivial enough that I'm tempted to push it straight to aurora and central!

It would be awesome if this was backported now we are on the whitelist for 41.

Comment 4

[Jean-Yves Avenard [:jya]]

the fix that introduced the regression was only uplifted to aurora (42) a few days ago. 41 isn't affected

Comment 5

[u514836]

Great news, thanks.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95bac0001e70

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/95bac0001e70

Comment 8

[Jean-Yves Avenard [:jya]]

This has regressed many MSE streams.. Can we get this in in priority?

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8661656 [details] [diff] [review]
[mp4] Don't reject 7 bytes long avcC atom.

Important regression, taking it.

Comment 10

[Jean-Yves Avenard [:jya]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1e3f704a18b9