Closed Bug 1205233 Opened 9 years ago Closed 9 years ago

[Presentation WebAPI] Make Presentation API available for browser chrome code

Categories

(Core :: DOM: Core & HTML, defect, P1)

defect

Tracking

()

RESOLVED FIXED
FxOS-S8 (02Oct)
feature-b2g 2.5+
Tracking Status
firefox44 --- fixed

People

(Reporter: schien, Assigned: selin)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file, 1 obsolete file)

We need to use Presentation API in browser chrome code for implementing bug 1129785.
Hi Josh,

Could you help mark 2.5+ to this one?
Flags: needinfo?(jocheng)
Attached patch Patch, v1 (obsolete) — Splinter Review
Remove "AvailableIn=" from presentation interfaces, so chrome scripts can use them. Yet the interfaces are still protected by "presentation" permission.
Attachment #8662275 - Flags: review?(bugs)
Comment on attachment 8662275 [details] [diff] [review]
Patch, v1

I'd like someone more familiar with permissions and different types of apps to check this too, so, perhaps fabrice can review this.

r+ assuming fabrice agrees.
Attachment #8662275 - Flags: review?(fabrice)
Attachment #8662275 - Flags: review?(bugs)
Attachment #8662275 - Flags: review+
feature-b2g: --- → 2.5+
Flags: needinfo?(jocheng)
Priority: -- → P1
Target Milestone: --- → FxOS-S8 (02Oct)
Comment on attachment 8662275 [details] [diff] [review]
Patch, v1

Review of attachment 8662275 [details] [diff] [review]:
-----------------------------------------------------------------

Works for me. In general it's a bad thing to have both a permission check and an "availableIn" annotation in webidl since we can end up with a mismatch between the webidl annotation and PermissionTable.jsm
I started working on fixing that in Bug 1195946
Attachment #8662275 - Flags: review?(fabrice) → review+
Attached patch Patch, v1Splinter Review
Updating based on the latest code base.
Attachment #8662275 - Attachment is obsolete: true
Attachment #8663520 - Flags: review+
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/06698874c104
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: