Closed
Bug 1205238
Opened 9 years ago
Closed 9 years ago
Will raise Element is not currently visible and may not be manipulated when calling tap_comment()
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
FxOS-S8 (02Oct)
People
(Reporter: sho, Unassigned)
References
Details
Attachments
(1 file)
Will raise Element is not currently visible and may not be manipulated when calling tap_comment(). we can add one line "Wait(self.marionette, timeout=120).until(expected.element_displayed(*self._comment_locator))" before line 119 of contact_form.py under contacts/regions
Blocks: mtbf-2015q3
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8664137 [details] [review] [gaia] ShakoHo:1205238 > mozilla-b2g:master Can you help to review the patch for this bug? Add one line of waiting to validate the tap element is appeared.
Attachment #8664137 -
Flags: review?(npark)
Attachment #8664137 -
Flags: review?(martijn.martijn)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8664137 [details] [review] [gaia] ShakoHo:1205238 > mozilla-b2g:master I'm fine with it, I made a comment in the pull request. In which test is this failing?
Attachment #8664137 -
Flags: review?(martijn.martijn) → review+
|
||
Comment 4•9 years ago
|
||
Comment on attachment 8664137 [details] [review] [gaia] ShakoHo:1205238 > mozilla-b2g:master looks good, minus the variable name reuse.
Attachment #8664137 -
Flags: review?(npark) → review+
it's test_mtbf_keyboard.py test case which is very similar to test_keyboard.py in gaiatest.
Keywords: checkin-needed
|
||
Comment 6•9 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/7e72976ec55a38d7a72d383eb8d3d797b75e71f1
Status: NEW → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in
before you can comment on or make changes to this bug.
Description
•