Closed Bug 1205253 Opened 4 years ago Closed 4 years ago

Move Bluetooth Core module into separate file

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
FxOS-S7 (18Sep)
Tracking Status
firefox43 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(2 files)

BluetoothDaemonInterface.cpp contains a mixture of different IPC modules (setup, core) and the overall protocol handling. The modules should be into their own files to make the source code more readable.

This bug report is about moving the Core module into its own source file.
Comment on attachment 8661741 [details] [diff] [review]
[01] Bug 1205253: Move |BluetoothDaemonCoreModule| into separate compilation unit

Review of attachment 8661741 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661741 - Flags: review?(btian) → review+
Comment on attachment 8661743 [details] [diff] [review]
[02] Bug 1205253: Use enum constants for Bluetooth Core module

Review of attachment 8661743 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8661743 - Flags: review?(btian) → review+
Thanks a lot, Ben! I have a number of cleanup patches in the queue. I'll post them one-by-one over the next days.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=5ef884a2b022
https://hg.mozilla.org/mozilla-central/rev/691a54f38d84
https://hg.mozilla.org/mozilla-central/rev/5ef884a2b022
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in before you can comment on or make changes to this bug.