Closed
Bug 1205253
Opened 6 years ago
Closed 6 years ago
Move Bluetooth Core module into separate file
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
FxOS-S7 (18Sep)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(2 files)
79.37 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
12.45 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
BluetoothDaemonInterface.cpp contains a mixture of different IPC modules (setup, core) and the overall protocol handling. The modules should be into their own files to make the source code more readable. This bug report is about moving the Core module into its own source file.
Assignee | ||
Comment 1•6 years ago
|
||
Attachment #8661741 -
Flags: review?(btian)
Assignee | ||
Comment 2•6 years ago
|
||
Attachment #8661743 -
Flags: review?(btian)
Comment 3•6 years ago
|
||
Comment on attachment 8661741 [details] [diff] [review] [01] Bug 1205253: Move |BluetoothDaemonCoreModule| into separate compilation unit Review of attachment 8661741 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8661741 -
Flags: review?(btian) → review+
Comment 4•6 years ago
|
||
Comment on attachment 8661743 [details] [diff] [review] [02] Bug 1205253: Use enum constants for Bluetooth Core module Review of attachment 8661743 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8661743 -
Flags: review?(btian) → review+
https://hg.mozilla.org/integration/b2g-inbound/rev/691a54f38d84 https://hg.mozilla.org/integration/b2g-inbound/rev/5ef884a2b022
Assignee | ||
Comment 6•6 years ago
|
||
Thanks a lot, Ben! I have a number of cleanup patches in the queue. I'll post them one-by-one over the next days. https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=5ef884a2b022
https://hg.mozilla.org/mozilla-central/rev/691a54f38d84 https://hg.mozilla.org/mozilla-central/rev/5ef884a2b022
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•