1205253 - Move Bluetooth Core module into separate file

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Thomas Zimmermann [:tzimmermann] [:tdz]]

BluetoothDaemonInterface.cpp contains a mixture of different IPC modules (setup, core) and the overall protocol handling. The modules should be into their own files to make the source code more readable.

This bug report is about moving the Core module into its own source file.

Comment 1

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [01] Bug 1205253: Move |BluetoothDaemonCoreModule| into separate compilation unit

Comment 2

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Attachment: [02] Bug 1205253: Use enum constants for Bluetooth Core module

Comment 3

[Ben Tian (inactive)]

Comment on attachment 8661741 [details] [diff] [review]
[01] Bug 1205253: Move |BluetoothDaemonCoreModule| into separate compilation unit

Review of attachment 8661741 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 4

[Ben Tian (inactive)]

Comment on attachment 8661743 [details] [diff] [review]
[02] Bug 1205253: Use enum constants for Bluetooth Core module

Review of attachment 8661743 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/691a54f38d84
https://hg.mozilla.org/integration/b2g-inbound/rev/5ef884a2b022

Comment 6

[Thomas Zimmermann [:tzimmermann] [:tdz]]

Thanks a lot, Ben! I have a number of cleanup patches in the queue. I'll post them one-by-one over the next days.

https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=5ef884a2b022

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/691a54f38d84
https://hg.mozilla.org/mozilla-central/rev/5ef884a2b022