1205282 - Enable auto-downloads for IE 9 and above when landing on scene 2 of /firefox/new/

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

When a user lands directly on scene 2 of /firefox/new/, we trigger the Firefox download automatically. The exception here is if the user is on IE < 11. For these older IE users, we suppress the auto-download and trigger it instead directly before they land on the /firefox/new/ page, to avoid the IE security prompt for file download.

Now that the old PHP site is gone and all locales for /firefox/new/ are now enabled on bedrock, we should be able to update these restrictions a little. Auto-downloads *should* actually work on IE 9 and above. The reason why it is currently IE < 11 was so the logic matched between the old and new site, but that restriction is now gone.

Comment 1

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 2

[Alex Gibson [:agibson]]

Hi Rebecca,

I was wondering if we could please spare some of your QA help testing this change? It's up on demo4 here:

https://www-demo4.allizom.org/en-US/firefox/new/?scene=2#download-fx

What we need to verify is that when an IE9 or IE10 user lands on this URL, it should now trigger an automatic download once the page has loaded.

If you test against prod, this should not currently happen (this is on purpose):

https://www.mozilla.org/en-US/firefox/new/?scene=2#download-fx

IE 11 and Edge users should be unaffected by this change, as they already get auto-downloads on the above URL. After this change is merged, it will only be IE 6/7/8 users who do not get the auto-download (we handle those cases differently).

We've tested this fairly thoroughly on our machines / VM's, but would be good to get some QA verification on this. Happy to explain things further in person if you have any immediate questions or if things aren't quite clear.

Thanks,

Alex

Comment 3

[Rebecca Billings [:rbillings]]

Testing on Windows 10 x 64 I got an automatic download for Firefox Setup Stub 40.0.3.exe on BOTH demo4 & prod, using Windows Edge.  Unfortunately I am unable to test IE9/10 on an earlier version of Windows due to current VM issues which I'm trying to resolve.

Comment 4

[Alex Gibson [:agibson]]

(In reply to Rebecca Billings [:rbillings] from comment #3)
> Testing on Windows 10 x 64 I got an automatic download for Firefox Setup
> Stub 40.0.3.exe on BOTH demo4 & prod, using Windows Edge. 

Yep, this is expected as we have always served auto-downloads to Edge. 

> Unfortunately I am unable to test IE9/10 on an earlier version of Windows due to current VM
> issues which I'm trying to resolve.

Ok thanks, do you expect to find a solution for your issue soon, or should I try and find someone else who has working VM's? :)

Comment 5

[Rebecca Billings [:rbillings]]

Verified auto-download on Win7/IE9, and Win8/IE10. Also saw that prod didn't auto-download when viewed on Win8/IE10.

Comment 6

[Alex Gibson [:agibson]]

(In reply to Rebecca Billings [:rbillings] from comment #5)
> Verified auto-download on Win7/IE9, and Win8/IE10. Also saw that prod didn't
> auto-download when viewed on Win8/IE10.

Great, thanks for testing Rebecca!

Comment 7

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/2462d086251ada978135b4cb50f54972c5f99730
[fix bug 1205282] Enable auto-downloads for IE 9 and above when landing on scene 2 of /firefox/new/

https://github.com/mozilla/bedrock/commit/c9d937afedb3a7f9534521d416f4876c110b8cc3
Merge pull request #3326 from mozilla/bug-1205282-enable-auto-downloads-ie9-and-above-firefox-new

[fix bug 1205282] Enable auto-downloads for IE 9 and above on scene 2 of /firefox/new/