Closed Bug 1205296 Opened 9 years ago Closed 9 years ago

ditch django-mobility

Categories

(Input Graveyard :: Code Quality, defect)

Product:
Input Graveyard
Component:
Code Quality
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

Details

(Whiteboard: p=1 s=input.2015q4) 

We use django-mobility (https://github.com/jbalogh/django-mobility) to determine whether or not to show a mobile view of a page.

However:

1. there have been no releases of django-mobility
2. ergo, it's not well maintained
3. we shouldn't be doing mobile views of pages anymore--this is 2015

This bug covers the following:

1. write up bugs for all the places we do mobile views of pages to ditch the mobile views
2. remove use of django-mobility by either rewriting that code in fjord or doing something different
New quarter!
Whiteboard: p= s=input.2015q3 → p= s=input.2015q4
We use mobile_template decorator for the following views:

* analytics/views.py:response_view
* base/views.py:new_user_view
* base/views.py:csrf_failure
* base/views.py:login_failure
* feedback/views.py:download_firefox

That's it. Once we fix those, then we don't need django-mobility at all.

Another way to do this is to re-implement mobile_template decorator--it's like five lines.

As a side note, I'm not sure we use download_firefox anymore. We should instrument that and see.

Grabbing this to do now.
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Whiteboard: p= s=input.2015q4 → p=1 s=input.2015q4
I implemented the "take mobile_template and stick it in fjord" idea.

In a PR: https://github.com/mozilla/fjord/pull/690
Pushed to prod just now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Input → Input Graveyard
You need to log in before you can comment on or make changes to this bug.