Disable Firefox Accounts in Guest Mode and in a Restricted profile

RESOLVED FIXED in Firefox 43

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

Trunk
Firefox 43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(3 attachments)

Right now, we don't stop the user creating a Firefox Account when they're in Guest or Restricted mode: if they can launch the appropriate native activity, they can arrange to have an Android Account pointing at the 'default' (non-Guest) profile.  I think we hide the Sync setting in Guest preferences, so the cow-path is not easy to find, and this probably happens infrequently.

As we move the FxA sign up flow onto the web, Fennec and Gecko need to actually run to complete the flow.  We need to anticipate these entry points.

There are two technical interventions here:

1) don't register the FxAccountsWebChannel landed in Bug 1191064 at all.  This means that an account should never be created if one doesn't exist.  (And an existing one can't be updated or controlled.)


2) make about:accounts refuse to load the fxa-content-server (as if the browser was not connected to the Internet) and display a "restricted profile" warning on all access.  If an account exists, and the user manages to start interacting with it, this should stop any actual change occurring.

This doesn't have to be in place on day one for FxA web sign in to be toggled on.
Bug 1205334 - Part 1: Don't register FxA WebChannel or listen for Accounts:* messages when restricted. r?sebastian
Attachment #8662539 - Flags: review?(s.kaspari)
Bug 1205334 - Part 2: Show an error message in about:accounts when restricted. r?sebastian
Attachment #8662540 - Flags: review?(s.kaspari)
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
antlam: please OK the following screen, shown in the unlikely event that a restricted profile ends up at about:accounts.

It's unlikely because the Sync option is removed from Preferences; but there are lots of ways to potentially get in, like: tapping on an old Sync notification after entering Guest mode, etc.  If you want copy changes, now is the time.
Attachment #8662542 - Flags: review?(alam)
Comment on attachment 8662542 [details]
about.accounts.restricted.profile.png

Although unlikely, let's try to keep consistent with our empty state designs for these pages.

See bug 1101746. 

Perhaps we could use that design here? That is, put this copy in the same style as the body copy of the empty about:logins page.
Flags: needinfo?(nalexander)
Attachment #8662542 - Flags: review?(alam) → review-
This existing copy is in the same "description" style as the copy from about:logins.

The copy is vertically centered because I vertically centered the spinner, which copies iOS, which centered for no particular reason.  I am happy to ape about:logins and have the spinner just a little down from the top.  antlam: do you want this?

There is no icon and no title.  antlam: do you want to provide an icon and title?
Flags: needinfo?(nalexander) → needinfo?(alam)
(In reply to Nick Alexander :nalexander from comment #5)
> This existing copy is in the same "description" style as the copy from
> about:logins.

I think it's because the copy approaches the edges here. Our empty states should have a max width of 240 px for that part. Maybe add that?

> The copy is vertically centered because I vertically centered the spinner,
> which copies iOS, which centered for no particular reason.  I am happy to
> ape about:logins and have the spinner just a little down from the top. 
> antlam: do you want this?

Centering the spinner is a good call :) Lets leave it

> There is no icon and no title.  antlam: do you want to provide an icon and
> title?

I don't have an icon or title in mind ATM. So, we can revisit this more holistically later. This will do for now (adding the side padding)

Thanks!
Flags: needinfo?(alam) → needinfo?(nalexander)
Attachment #8662539 - Flags: review?(s.kaspari) → review+
Comment on attachment 8662539 [details]
MozReview Request: Bug 1205334 - Part 1: Don't register FxA WebChannel or listen for Accounts:* messages when restricted. r?sebastian

https://reviewboard.mozilla.org/r/19629/#review17675
Comment on attachment 8662540 [details]
MozReview Request: Bug 1205334 - Part 2: Show an error message in about:accounts when restricted. r?sebastian

https://reviewboard.mozilla.org/r/19631/#review17677
Attachment #8662540 - Flags: review?(s.kaspari) → review+
antlam and I OKed the copy face-to-face.
Flags: needinfo?(nalexander)
https://hg.mozilla.org/mozilla-central/rev/58045af5f295
https://hg.mozilla.org/mozilla-central/rev/39669760cd58
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.