Always do shutdown CCs when NS_FREE_PERMANENT_DATA is defined.

RESOLVED FIXED in Firefox 43

Status

()

Core
XPCOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8661880 [details] [diff] [review]
Always do shutdown CCs when NS_FREE_PERMANENT_DATA is defined. r=smaug
(Assignee)

Comment 2

2 years ago
Valgrind also sets this environment variable, but I can't tell if it has NS_FREE_PERMANENT_DATA defined, so I left its thing that sets it.
Assignee: nobody → continuation
Blocks: 1205342
(Assignee)

Updated

2 years ago
Attachment #8661880 - Attachment is obsolete: true
(Assignee)

Comment 3

2 years ago
Created attachment 8661894 [details] [diff] [review]
Always do shutdown CCs when NS_FREE_PERMANENT_DATA is defined.

git bz file is still a little clunky.

I should make sure this actually works before asking for review.
(Assignee)

Comment 4

2 years ago
Comment on attachment 8661894 [details] [diff] [review]
Always do shutdown CCs when NS_FREE_PERMANENT_DATA is defined.

NS_FREE_PERMANENT_DATA is defined in DEBUG and ASan builds.
Attachment #8661894 - Flags: review?(bugs)
(Assignee)

Comment 5

2 years ago
ASan try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c0d0cbd694b3
Attachment #8661894 - Flags: review?(bugs) → review+
(Assignee)

Comment 6

2 years ago
debug try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=210a2fad016b
Keywords: checkin-needed

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/26529dbf90ad
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/26529dbf90ad
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.