1205357 - Fall Campaign Landing Page - Implementation

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

This bug executes the development for the Fall campaign landing page. Designs are in bug 1205356.

Comment 1

[Schalk Neethling [:espressive]]

Attachment: Link to Github pull-request: https://github.com/mozilla/bedrock/pull/3354

Initial WIP pull request

Comment 2

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Designs/copy final in bug 1205356

Comment 3

[Schalk Neethling [:espressive]]

So, the heading strings in the concepts were much longer than the final strings and having it wrap, made sense. With the final strings I am unsure whether want to wrap them explicitly or, have them on one line, except for smaller viewport where it will naturally wrap.

Which is preferred?

Comment 4

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Final URL is /firefox/choose/

Working on an answer to your headline question.

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Schalk Neethling [:espressive] from comment #3)
> So, the heading strings in the concepts were much longer than the final
> strings and having it wrap, made sense. With the final strings I am unsure
> whether want to wrap them explicitly or, have them on one line, except for
> smaller viewport where it will naturally wrap.
> 
> Which is preferred?

Hi Schalk,

The team met, and we think it would be best if we broke the line ourselves. So

Browse freely.
Choose Firefox.

etc.

This is on the assumption that the headlines of the two supporting blurbs (The most private browsing, etc) are still above the fold (which from the designs in comment 2, seems to be the case).

Thanks!

NI espressive to make sure it's caught, since we're late on this one.

Comment 6

[Schalk Neethling [:espressive]]

Got it, thanks!

Comment 7

[Schalk Neethling [:espressive]]

Where should the links for the two blurbs point to?

1) "Learn more about this"
2) "Get smart on data tracking"

Comment 8

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Schalk Neethling [:espressive] from comment #7)
> Where should the links for the two blurbs point to?
> 
> 1) "Learn more about this"

https://mozilla.org/firefox/private-browsing/
(this page: bug 1196569)

> 2) "Get smart on data tracking"

NI malexis, jbertsch - do we know the URL for this page?

Comment 9

[Jennifer Bertsch [:jbertsch]]

+Craig for Smart on tracking protection URL

Comment 10

[Craig Cook (:craigcook)]

(In reply to Jennifer Bertsch [:jbertsch] from comment #9)
> +Craig for Smart on tracking protection URL

It will be: mozilla.org/teach/smarton/tracking/ 
or for Python: {{ url('teach.smarton.tracking') }}

However, the Python URL will of course throw an error until the page is defined, so you'll probably want to put in a placeholder and make a note to update it once the smarton tracking page lands in master.

Comment 11

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Copy document has been updated with <title> and <description>
https://docs.google.com/document/d/1BN0brWqkOK5-HE_uP1EzR0amVq_uWwonDNo_46HKe6k/edit

Flod: the team was fine with both of these that were already in the template (still trying to track down where these came from). However, some of the formatting on the <title> needs updating (lower case B on browser).

Comment 12

[Francesco Lodolo [:flod]]

Firefox Web Browser -> Firefox Web browser 

This string (with uppercase Browser) was already used in another page
https://www.mozilla.org/en-US/firefox/independent/

"Keep your identity yours with the new Firefox" lost the final period.

As minor as they look, both changes invalidate the existing translations (16 locales so far).

We can:
1. Put a conditional in the template to use the new strings only in en-US.
2. Update the reference strings and keep the existing localizations.
3. Expose new strings for title and description. In this case, we can also use completely different strings since we're already breaking string freeze.

If we go with #3, please provide the new strings as soon as possible.

Comment 13

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Hi Flod,

Given that the period and the hyphen are changing, we need to go with #3. Copy document has been updated.

Firefox Web browser — Keep your identity yours with the new Firefox — Mozilla

Sorry for the change here. Not entirely sure how these strings made it into the template (although we should have had it in the copy document).

Comment 14

[Francesco Lodolo [:flod]]

> Firefox Web browser — Keep your identity yours with the new Firefox — Mozilla

@espressive
Is it technically possible to expose this a single string (the Private Browsing landing page is doing it)? In the past we had requests to avoid using "—" as hard-coded separator in the title, exposing one string for the entire title would help with that.

Comment 15

[Schalk Neethling [:espressive]]

(In reply to Francesco Lodolo [:flod] from comment #14)
> > Firefox Web browser — Keep your identity yours with the new Firefox — Mozilla
> 
> @espressive
> Is it technically possible to expose this a single string (the Private
> Browsing landing page is doing it)? In the past we had requests to avoid
> using "—" as hard-coded separator in the title, exposing one string for the
> entire title would help with that.

WE can expose it as such:

"Firefox Web browser — Keep your identity yours with the new Firefox — Mozilla" - means the — will be part of the string though. If that is fine, I can change it to be so.

Comment 16

[Francesco Lodolo [:flod]]

(In reply to Schalk Neethling [:espressive] from comment #15)
> WE can expose it as such:
> 
> "Firefox Web browser — Keep your identity yours with the new Firefox —
> Mozilla" - means the — will be part of the string though. If that is fine, I
> can change it to be so.

On second thoughts, let's expose 2 strings
Firefox Web browser
Keep your identity yours with the new Firefox

While it's nice to make "—" localizable, I also don't want locales to mess with the title structure.

I'll keep the existing translations and ask localizers to double check them.

Comment 17

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/129f74e9321d13f613c8be79af6670e0f7f8784f
Fix Bug 1205357, implement fall campaign landing page

https://github.com/mozilla/bedrock/commit/e33267437606c3d849e1306000921f353ba0a50a
Merge pull request #3354 from schalkneethling/bug1205357-fall-campaign-landing-page

Fix Bug 1205357, implement fall campaign landing page

Comment 18

[Francesco Lodolo [:flod]]

I was doing some string searches on "Get smart on Tracking", and found out that the link on the landing page is pointing to privacy/tips
https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templates/firefox/choose.html#L64

Is it wanted?

Comment 19

[Francesco Lodolo [:flod]]

Found my answer in bug 1213891 thanks to :agibson.