Closed Bug 1205385 Opened 4 years ago Closed 4 years ago

Focus urlbar when search suggestions opt-in is dismissed only after pressing an opt-in accesskey

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [suggestions][fxsearch])

Attachments

(1 file)

Attached patch patchSplinter Review
+++ This bug was initially created as a clone of Bug #1203724 +++

I just noticed after bug 1203724 landed that it focuses the urlbar whenever the suggest.searches pref changes -- which is not exactly right.  That means that whenever you toggle the related checkbox in the Search pref pane, the location bar gets focused, which is wrong.

Should only focus it in the onclick handler for the buttons.  I tested this patch manually and it does work right.
Attachment #8661976 - Flags: review?(mak77)
Assignee: nobody → adw
Status: NEW → ASSIGNED
Comment on attachment 8661976 [details] [diff] [review]
patch

Review of attachment 8661976 [details] [diff] [review]:
-----------------------------------------------------------------

ugh
Attachment #8661976 - Flags: review?(mak77) → review+
Rank: 20
https://hg.mozilla.org/mozilla-central/rev/87008f7ea9d0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.