1205398 - [e10s] can't properly drag-n-drop tabs on OSX because dndPanel gets underneath the mouse pointer

Status: RESOLVED DUPLICATE of bug 1204944

(Firefox :: Tabbed Browser, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: patch

The panels should be transparent to the mouse, otherwise it's not possible to reorder tabs or drop them in another window, as the panel sits underneath the mouse pointer.

(Don't know if the panel being underneath the pointer is a bug or not, but in any way this fix probably makes sense by itself)

Comment 1

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/005290f8c1d5

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/005290f8c1d5

Comment 3

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/fx-team/rev/81cb24e420d1

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Backed out due to bug 1206508. I'm changing this bug's title to reflect the problem at hand and try other solutions.

There are three main issues with the dnd panel on OSX (retina-only I suppose) that is causing problems:
 1 - the panel appears underneath the mouse pointer, making mousemove operations go to the panel and not the window behind, which in turn makes the drag-n-drop operation not work while the mouse is on it
 2 - the panel is double of the size than it used to be. I should say that they look nice like this, but I'm not sure if this was an intentional or if it's a consequence of the retina display
 3 - the panel move by half the distance that the mouse pointer move, masquerading somewhat problem #1 as the mouse is able to get out of the way of the panel if moved far enough

I'll see which problems I can fix in this bug and which are better left to another one. I'm hoping that fixing #2 is going to fix the positioning (prob #1) but I'm not sure. #3 is most likely to be left separate unless it's a really direct change to fix it together here

Comment 5

[Neil Deakin]

Issues 1 and 3 are bug 1204944.

Comment 6

[:Felipe Gomes (needinfo for replies!)]

Ah ok, thanks Neil. I'll dupe this bug to yours, and I'll file another one for issue 2.

Btw, would you have any guess on why the patch that I landed here would cause the visual glitches in bug 1206508?

Comment 7

[Neil Deakin]

While not strictly necessary, since the tabdrag panel doesn't appear over the mouse cursor, I would still add the mousethrough and check the patch in this bug in however.