1205412 - Perfherder highlights the datapoints at 2 places for a revision hash with 2 graphs

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[Vaibhav (:vaibhav1994)]

Proof Of Concept:

1) Go to https://treeherder.mozilla.org/perf.html#/graphs?timerange=604800&series=[mozilla-inbound,f13794d806d6d13be658077bd52fdd885521e8f8,1]&series=[fx-team,f13794d806d6d13be658077bd52fdd885521e8f8,1]&highlightedRevisions=d81b35757962

2) There will be 2 datapoints highlighted, one for 6feccf342e7c on sept 10th and one for 15f2e2c86ca9 on sept 15th. Only sept 15th one is right.

Comment 1

[Vaibhav (:vaibhav1994)]

Another thing I noticed is that if we put the second graph to display off, example: https://treeherder.mozilla.org/perf.html#/graphs?timerange=604800&series=[mozilla-inbound,f13794d806d6d13be658077bd52fdd885521e8f8,1]&series=[fx-team,f13794d806d6d13be658077bd52fdd885521e8f8,0]&highlightedRevisions=d81b35757962

then it correctly shows a single datapoint highlighted on sept 15th.

Comment 2

[William Lachance (:wlach)]

Attachment: PR

This was happily easy to fix.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8662066 [details] [review]
PR

great find and great fix!

Comment 5

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bdafc6d944b9fb0021802cba16b19b19cff608ca
Bug 1205412 - Fix highlighting of revisions in perf graphs

When we had two series with the same signature on different branches, we
would incorrectly highlight two points on the same graph instead of
highlighting the relevant revisions on each. This used to work because
we associated a branch with each series signature, so could identify
them uniquely before, but we don't do this any more. Fortunately the fix here
is simple: just use the previously defined series instead of trying to
look it up all over again.

https://github.com/mozilla/treeherder/commit/cdd43cce79c45848272f3d36cc498f76f87be718
Merge pull request #970 from wlach/1205412

 	Bug 1205412 - Fix highlighting of revisions in perf graphs