Closed Bug 120543 Opened 21 years ago Closed 21 years ago

Software error when entering a bug when not logged in & only one product

Categories

(Bugzilla :: Creating/Changing Bugs, defect)

Product:
Bugzilla
Component:
Creating/Changing Bugs
Version:
2.15
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: bbaetz, Assigned: bbaetz)

Details

Attachments

(1 file)

fix
804 bytes, patch
caillon
: review+
jacob
: review+
Details | Diff | Splinter Review 
If you have only one product && you are not logged in, then trying to enter a
new bug will give a software error. This is because enter_bug.cgi sets
$FORM{'product'}, and CGI.pl, when copying form values for confirm_login,
iterates through keys $FORM, looking at $MFORM to work out if its multiple entry
or not.

confirm_login should be more robust; one liner coming up
Attached patch fix — — Splinter Review 
Check |defined $MFORM{$i}| before counting how many values it contains.
Also see the comments in bug 100100.
Comment on attachment 65426 [details] [diff] [review]
fix

Simple, makes sence, doesn't cause any problems.
r=jake
Attachment #65426 - Flags: review+
Checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
fixing incorrect milestones on fixed bugs.
Target Milestone: --- → Bugzilla 2.16
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.