1205431 - [regression] Cannot profile latest b2g since bug 1171488

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Bug 1171488 introduced attaching system information to recordings for debugging. When starting a recording, an error is throw at:

Exception: "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]
resource://gre/modules/devtools/shared/system.js::getSetting::line 294

Recreatable on build 43.0a1 - 20150914150204

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The getSetting code is not correct for working in the child process.  We should use a try / catch as a quick fix and file a follow up to make it work for real.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1205431-b2g-getsettings.patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9f56f43af50f

Not sure how to even write a test for this.. or even test it..

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8662544 [details] [diff] [review]
1205431-b2g-getsettings.patch

Review of attachment 8662544 [details] [diff] [review]:
-----------------------------------------------------------------

To be nice to other callers of `getSetting`, also add a try / catch inside that method that rejects its promise in case of error.

The failure is currently on the `let settingsService = Cc["@mozilla.org/settingsService;1"].getService(Ci.nsISettingsService);` line, so we get inside the current if.

You'll still need the try you already added, since the promise will be rejected.

Not aware of a good way to test this today, unfortunately.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1205431-b2g-getsettings.patch

Made those changes
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ddb6e3306c41

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/6b14b48d1883

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b14b48d1883