1205450 - Imagecompare: test_combo_effects_edit_picture.py fails because of missing import

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Comment 1

[No-Jun Park [:njpark]]

Turns out when there was a global search and replace applied to use expected. call, the appropriate import statement wasnt' added:

:38.62 TEST_START: MainThread test_combo_effects_edit_picture.py TestGalleryEditPhotoComboEffect.test_combo_effects_edit_picture
5:42.87 TEST_END: MainThread ERROR, expected PASS
Traceback (most recent call last):
 File "<http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.nightly.ui.graphics.reference_nonsmoke.bitbar/ws/.env/lib/python2.7/site-packages/marionette_client-0.17-py2.7.egg/marionette/marionette_test.py",> line 296, in run
   testMethod()
 File "<http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.nightly.ui.graphics.reference_nonsmoke.bitbar/ws/tests/python/gaia-ui-tests/gaiatest/tests/graphics/test_combo_effects_edit_picture.py",> line 15, in test_combo_effects_edit_picture
   self.gallery_edit_photo('IMG_0001.jpg')
 File "<http://jenkins1.qa.scl3.mozilla.com/job/flame-kk-319.mozilla-central.nightly.ui.graphics.reference_nonsmoke.bitbar/ws/tests/python/gaia-ui-tests/gaiatest/tests/graphics/edit_picture_base.py",> line 62, in gallery_edit_photo
   Wait(self.marionette).until(expected.element_displayed(*self._crop_aspect_square_button))
NameError: global name 'expected' is not defined

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1205450 > mozilla-b2g:master

Comment 3

[No-Jun Park [:njpark]]

Comment on attachment 8662087 [details] [review]
[gaia] npark-mozilla:1205450 > mozilla-b2g:master

quick fix

Comment 4

[No-Jun Park [:njpark]]

Merged:
https://github.com/mozilla-b2g/gaia/commit/71d8d7c95600cd72b7b06f6c79e71d98aa4e9394