Closed
Bug 1205486
Opened 9 years ago
Closed 9 years ago
Marionette crash under ~nsStyleContext due to CSSVariableImageTable manipulation
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla43
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
References
Details
Attachments
(1 file)
|
1.55 KB,
patch
|
seth
:
review+
|
Details | Diff | Splinter Review |
Dry runs of the upcoming central -> aurora merge result in crashes in Marionette: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8cdb09267b6 Seth diagnosed this to be probably due to re-entrant manipulation of the CSSVariableImageTable (as releasing objects in that table cause other style contexts to be released and thus removed from the same table).
|
Assignee | |
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d656fd53f2a1
|
|
Assignee | |
Comment 2•9 years ago
|
||
And with central-as-aurora patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=06a0d183a944
|
|
Assignee | |
Comment 3•9 years ago
|
||
Something that compiles and doesn't assert: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5de9868f74ec
|
|
Assignee | |
Comment 4•9 years ago
|
||
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8662235 [details] [diff] [review] patch Review of attachment 8662235 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! Thanks for getting this fixed, Cameron.
Attachment #8662235 -
Flags: review?(seth) → review+
https://hg.mozilla.org/mozilla-central/rev/db852503a55f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in
before you can comment on or make changes to this bug.
Description
•