Add explanatory note to parent review dialog

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mcote, Assigned: mcote)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Parent review requests continue to confuse people.  We need to add a note explaining what they're for, to at least the review dialog.  The main commits view might need one too, but that can be done separately.
(Assignee)

Comment 1

3 years ago
Created attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add explanatory note to review dialog for parent requests (bug 1205488). r?mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.

I'm also not sure "MRParents" is a good name for the JavaScript extension,
but I'm not sure what is.
Attachment #8662111 - Flags: review?(mdoglio)
https://reviewboard.mozilla.org/r/19507/#review17531

For the extension name, what about ParentReviewMessage or something like that?

::: pylib/mozreview/mozreview/static/mozreview/js/parents.js:21
(Diff revision 1)
> +  initialize: function() {
> +    _super(this).initialize.call(this);
> +  }

Isn't this superfluous?

Can you please attach a screenshot of the message?
(Assignee)

Comment 3

3 years ago
https://reviewboard.mozilla.org/r/19507/#review17531

So this is what I was torn about--do we have one extension that may later include more things, in which case we want a more generic name, or do we use multiple extensions, in which case we have more specific names?  I feel like it should be the former, since we can have a bunch of different hook views, but I'm not sure.  Maybe this is a question for smacleod.
(Assignee)

Comment 4

3 years ago
Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add explanatory note to review dialog for parent requests (bug 1205488). r?mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.

I'm also not sure "MRParents" is a good name for the JavaScript extension,
but I'm not sure what is.
Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

https://reviewboard.mozilla.org/r/19509/#review17667
Attachment #8662111 - Flags: review?(mdoglio) → review+
(Assignee)

Comment 8

3 years ago
Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.
Attachment #8662111 - Attachment description: MozReview Request: mozreview: Add explanatory note to review dialog for parent requests (bug 1205488). r?mdoglio → MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio
(Assignee)

Comment 9

3 years ago
Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.
(Assignee)

Updated

3 years ago
Attachment #8662111 - Flags: review+ → review?(mdoglio)
Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

https://reviewboard.mozilla.org/r/19509/#review21251
Attachment #8662111 - Flags: review?(mdoglio) → review+
(Assignee)

Comment 11

3 years ago
Comment on attachment 8662111 [details]
MozReview Request: mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

mozreview: Add warning to main view and review dialog for parent requests (bug 1205488). r=mdoglio

Parent review requests continue to confuse people.  This is a simple attempt
to clarify what they're for, although this won't eliminate all confusion,
particularly when there is only one child.
(Assignee)

Comment 12

3 years ago
Okay I really wanted to add a note to the diff-comment dialog, since, as smacleod pointed out, if you go directly to the diff it scrolls you down, often past the main panel entirely.  That means people may not see the warning until they click "Finish Review..." which is kind of rude, as they may have already entered a bunch of comments.  But I could not figure out how to add text to the diff-comment dialog and get it to resize properly.  I really want to land the rest of this, so maybe we can follow up later.

http://hg.mozilla.org/hgcustom/version-control-tools/rev/c828c8876354
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.