Closed Bug 1205495 Opened 4 years ago Closed 4 years ago

Restore the body and redirect properties of the request object in dom/tests/mochitest/fetch/reroute.js

Categories

(Core :: DOM: Service Workers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox43 --- fixed
firefox44 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

See bug 1204596 comment 9.
Status: NEW → ASSIGNED
Attached patch Patch (v1)Splinter Review
Attachment #8664240 - Flags: review?(nsm.nikhil)
Comment on attachment 8664240 [details] [diff] [review]
Patch (v1)

Review of attachment 8664240 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/fetch/reroute.js
@@ +5,5 @@
>      var url = e.request.url.substring(0, e.request.url.indexOf('?'));
>      url += '?headers=' + ({ 'Referer': self.location.href }).toSource();
>  
> +    e.respondWith(e.request.text().then(function(text) {
> +      var body = text === '' ? undefined : text;

Why is this check needed instead of just sending the empty body?
Attachment #8664240 - Flags: review?(nsm.nikhil) → review+
Sending an empty body confuses something, I think in the CORS test server, but I don't think it's worth spending the time to figure out why.
https://hg.mozilla.org/mozilla-central/rev/073088c002de
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
checkin-needed for the uplift of this test only change on Aurora.  Thanks!
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.