1205495 - Restore the body and redirect properties of the request object in dom/tests/mochitest/fetch/reroute.js

Status: RESOLVED FIXED

(Core :: DOM: Service Workers, defect)

Description

[(no longer active)]

See bug 1204596 comment 9.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8664240 [details] [diff] [review]
Patch (v1)

Review of attachment 8664240 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/tests/mochitest/fetch/reroute.js
@@ +5,5 @@
>      var url = e.request.url.substring(0, e.request.url.indexOf('?'));
>      url += '?headers=' + ({ 'Referer': self.location.href }).toSource();
>  
> +    e.respondWith(e.request.text().then(function(text) {
> +      var body = text === '' ? undefined : text;

Why is this check needed instead of just sending the empty body?

Comment 3

[(no longer active)]

Sending an empty body confuses something, I think in the CORS test server, but I don't think it's worth spending the time to figure out why.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/073088c002de

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/073088c002de

Comment 6

[(no longer active)]

checkin-needed for the uplift of this test only change on Aurora.  Thanks!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/18f38260f260