Closed
Bug 1205495
Opened 9 years ago
Closed 9 years ago
Restore the body and redirect properties of the request object in dom/tests/mochitest/fetch/reroute.js
Categories
(Core :: DOM: Service Workers, defect)
Core
DOM: Service Workers
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
1.02 KB,
patch
|
nsm
:
review+
|
Details | Diff | Splinter Review |
Updated•9 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8664240 -
Flags: review?(nsm.nikhil)
Comment on attachment 8664240 [details] [diff] [review] Patch (v1) Review of attachment 8664240 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/tests/mochitest/fetch/reroute.js @@ +5,5 @@ > var url = e.request.url.substring(0, e.request.url.indexOf('?')); > url += '?headers=' + ({ 'Referer': self.location.href }).toSource(); > > + e.respondWith(e.request.text().then(function(text) { > + var body = text === '' ? undefined : text; Why is this check needed instead of just sending the empty body?
Attachment #8664240 -
Flags: review?(nsm.nikhil) → review+
Assignee | ||
Comment 3•9 years ago
|
||
Sending an empty body confuses something, I think in the CORS test server, but I don't think it's worth spending the time to figure out why.
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/073088c002de
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Assignee | ||
Comment 6•9 years ago
|
||
checkin-needed for the uplift of this test only change on Aurora. Thanks!
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/18f38260f260
status-firefox43:
--- → fixed
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•