Closed Bug 1205570 Opened 9 years ago Closed 9 years ago

set up x-math lang group font preferences correctly

Categories

(Core :: Graphics: Text, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jtd, Assigned: jtd)

References

Details

Attachments

(1 file)

It looks like the prefs code was changed so that math fonts could be specified and lang="x-math" specified on elements. The problem with the implementation is that this wasn't added to the list of lang groups tracked within gfx code, so any gfxFontGroup with lang=x-math won't pick up the right pref fonts. After recent changes, there just needs to be a line added to gfxFontPrefLangList.h and a few tweaks to all.js.
Comment on attachment 8662716 [details] [diff] [review]
patch, fix up font prefs for x-math lang group

Review of attachment 8662716 [details] [diff] [review]:
-----------------------------------------------------------------

It'd be good to assert the comment at the top of gfxFontPrefLangList.h (that the list must be in sync with the prefs).  I'll see what I can do about that in a separate bug.
Attachment #8662716 - Flags: review?(cam) → review+
https://hg.mozilla.org/mozilla-central/rev/1ab076078dc3
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: