Closed
Bug 1205577
Opened 9 years ago
Closed 9 years ago
Use enum constants in Socket module
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(firefox43 fixed)
RESOLVED
FIXED
FxOS-S7 (18Sep)
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(1 file)
2.78 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
The Socket module for Bluetooth should use enum constants, instead of hard-coding magic values.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8662257 -
Flags: review?(btian)
Comment 2•9 years ago
|
||
Comment on attachment 8662257 [details] [diff] [review] [01] Bug 1205577: Use enum constants for Bluetooth Socket module Review of attachment 8662257 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8662257 -
Flags: review?(btian) → review+
Assignee | ||
Comment 4•9 years ago
|
||
Thanks! https://treeherder.mozilla.org/#/jobs?repo=b2g-inbound&revision=2aec63c0c2bd
https://hg.mozilla.org/mozilla-central/rev/2aec63c0c2bd
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox43:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S7 (18Sep)
You need to log in
before you can comment on or make changes to this bug.
Description
•