Open Bug 1205593 Opened 4 years ago Updated 4 years ago

mozlog is still versioned 3.0 but does not match version 3.0 on pypi

Categories

(Testing :: Mozbase, defect)

defect
Not set

Tracking

(Not tracked)

People

(Reporter: glandium, Unassigned)

Details

I was confused when mozscreenshot would fail on
       from mozlog.formatters.process import strstatus
    ImportError: No module named process

on my machine when the installed mozlog matched the version listed on automation (3.0). And it turns out it was because the version I got somehow came from https://pypi.python.org/pypi/mozlog , but the version in the test package is also 3.0 but is different. The version on pypi doesn't have mozlog.formatters.process, the one in the test package does.

Fun fact: https://github.com/mozilla/mozlog is not /this/ mozlog.
We do not release a new version of mozlog to PyPI each time a change gets landed on mozilla-central. Instead we wait until it is wanted or necessary. Then the version gets bumped up and the release uploaded to PyPI.

So if you need this feature in an official release, please tell so and we can get a new release out.
This is not a "release it" bug. It's a "change the version number" bug. That is, right after you release version x, bump the version number so that it doesn't pretend to be that released version. Also, I guess mozscreenshot needs a dependency on a version of mozlog strictly greater than 3.0.
(In reply to Mike Hommey [:glandium] from comment #2)
> This is not a "release it" bug. It's a "change the version number" bug. That
> is, right after you release version x, bump the version number so that it
> doesn't pretend to be that released version.

That's how it is handled right now for all mozbase packages. There is no additional version bump to lets say 3.1pre after a release has been done. If that is necessary it might be good to get a discussion started about the workflow change in the tools mailing list.

> Also, I guess mozscreenshot needs a dependency on a version of mozlog strictly greater than 3.0.

I will cc Julien who created this package.
Well, yeah we can require a mozlog >= 3.0 dependency for mozscreenshot.

I am wondering, how did you get that error ? mozscreenshot is not released on pypi, it is an internal package only, intended to be used in conjunction with other in-tree mozbase package. It was created to reduce code duplication for mochitest and reftest, see bug 1091285.
(In reply to Julien Pagès from comment #4)
> Well, yeah we can require a mozlog >= 3.0 dependency for mozscreenshot.

You mean > 3.0.

> I am wondering, how did you get that error ? mozscreenshot is not released
> on pypi, it is an internal package only, intended to be used in conjunction
> with other in-tree mozbase package. It was created to reduce code
> duplication for mochitest and reftest, see bug 1091285.

I ended up in this situation probably because I let pip install things from pypi when installing the mozbase requirements, so I presume it used the packages from pypi instead of the local copies. This may or may not be related to the versions being the same, I haven't looked in detail.
You need to log in before you can comment on or make changes to this bug.