1205596 - [Settings]A alert "An unknown error occurred" pops up when user enters wrong PIN 2 and then changes to new PIN2.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
[Aries KK v2.5][Flame KK v2.5][Settings]When user enters wrong PIN2 and inputs correct PUK2 and new PIN 2, then tapping Done,  a alert "An unknown error occurred" pops up although PIN2 has been modified successfully.

Found at: 14:37
Attach: logcat_1437.txt and FDN_Aries_v2.5.3gp.

[2.Testing Steps]: 
1. Go to Settings-> Call Settings, try to enable FDN.
2. Enter wrong PIN 2 three times. 
3. Enter correct PUK2 and new PIN 2 code, then tap Done.



[3.Expected Result]: 
3. The alert "An unknown error occurred" should not pop up.

[4.Actual Result]: 
3. The alert "An unknown error occurred" pops up although PIN2 is modified successfully.

[5.Reproduction build]: 
Device: Flame KK 2.2 (Unaffected) 
Build ID               20150916032501
Gaia Revision          409a105b5b8aa93a47952b2899e6935b0e4bd194
Gaia Date              2015-09-15 19:23:55
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b857fca4824f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150916.065148
Firmware Date          Wed Sep 16 06:51:59 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5 (Affected)
Build ID               20150916150204
Gaia Revision          db6664f0e07e9966283d30cfc7006151fe7103ff
Gaia Date              2015-09-16 10:18:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e7d613b3bcfe1e865378bfac37de64560d1234ec
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150916.183723
Firmware Date          Wed Sep 16 18:37:40 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Affected)
Build ID               20150916190454
Gaia Revision          db6664f0e07e9966283d30cfc7006151fe7103ff
Gaia Date              2015-09-16 10:18:07
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/e7d613b3bcfe1e865378bfac37de64560d1234ec
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150916.182549
Firmware Date          Wed Sep 16 18:25:57 UTC 2015
Bootloader             s1


[6.Reproduction Frequency]: 
Always Recurrence,6/6

[7.TCID]: 
9036

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: FDN_Aries_v2.5.3gp

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: logcat_1437.txt

Comment 3

[Norry.L.F(Leave from Mozilla)]

Hi Gerry,

Could you help dispatch the bug? thanks :)

Comment 4

[Gerry Chang [:gchang]]

Hi Fred,
Can you help to dispatch this to right owner?

Comment 5

[[e-mail]]

[Blocking Requested - why for this release]: regression happens in 2.5 but not in 2.2

ask for regression window

Comment 6

[John Thomas [:Johnt]]

B2g Inbound Regression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150415220025
Gaia: 57fade7eed933aac78af0d840cac6206f0019b34
Gecko: deb611aec933
Version: 40.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150416015524
Gaia: 0bfa1219536af541d55d59ed00359f95a8698623
Gecko: 8101a808d801
Version: 40.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Last Working gaia / First Broken gecko - This issue does NOT occur with broken Gecko
Gaia: 57fade7eed933aac78af0d840cac6206f0019b34
Gecko: 8101a808d801

Last Working gecko / First Broken gaia - This issue DOES occur with broken Gaia
Gecko: 8101a808d801
Gaia: 0bfa1219536af541d55d59ed00359f95a8698623

B2g Inbound Pushlog: 
https://github.com/mozilla-b2g/gaia/compare/57fade7eed933aac78af0d840cac6206f0019b34...0bfa1219536af541d55d59ed00359f95a8698623

This issue is caused by Bug 1141973

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Eregon, this issue seems to have been caused by the changes for bug 1141973.  Can you please take a look?

Comment 8

[[e-mail]]

EJ is inactive now, I'll take cover that..

Comment 9

[Mahendra Potharaju [:mahe]]

Blocks 2.5 with a P2 priority. Broken and misleading behavior

Comment 10

[[e-mail]]

Bug 1145332 seems related, I just merge that patch to master, could you help verify if this issue still happens? Thanks.

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Setting qawanted to check this when we have a build with the landing in.

Comment 12

[John Thomas [:Johnt]]

This issue is resolved fixed on Flame 2.5.
Result: "An unknown error occurred" error message no longer appears when entering the wrong PUK code several times.

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (512mb)
Build ID: 20151002030232
Gaia: 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Gecko: 5f16c6c2b969f70e8da10ee34853246d593af412
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 13

[John Thomas [:Johnt]]

Correction: This issue DOES still occur. Please disregard my previous comment 12.
Result: "An unknown error occurred" still appears after entering correct PUK2 code.

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (512mb)
Build ID: 20151002030232
Gaia: 9a682cb7bc8b7fde624a9b2b3c2d64415a08b04b
Gecko: 5f16c6c2b969f70e8da10ee34853246d593af412
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 44.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Fred this issue still occurs when bug 1145332 has been fixed.

Comment 15

[[e-mail]]

Seems we got the wrong simpin number (should be pin1) since Aries only have 1 SIM card.
So the following settings are incorrect.

Comment 16

[[e-mail]]

Ooh I miss understand the function. For this case (unlock FDN), we do need pin2 and puk2 code.

Comment 17

[[e-mail]]

got message when reproducing the bug:

IccCardLockError event Error: []: invalid event name: puk2-changed

Add `puk2-changed` in EventEmitter list could solve it
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/modules/sim_security.js#L35


But I think the correct return value might be `pin2-changed` (because the fact is pin2 changed, not puk2 changed)?

Comment 18

[GitHub Autolander Bot]

Attachment: [gaia] gasolin:issue-1205596 > mozilla-b2g:master

Comment 19

[[e-mail]]

After digging further into code, I found `puk2-changed` is a composed event that denotes `lockType` and `status`(change pin1 or pin2), so its a gaia event and we have to handle it.

Comment 20

[[e-mail]]

Comment on attachment 8673017 [details] [review]
[gaia] gasolin:issue-1205596 > mozilla-b2g:master

we need provide missing 'puk2-changed' case for EventEmitter to prevent throw the generic error message

Comment 21

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Fred Lin [:gasolin] from comment #19)
> After digging further into code, I found `puk2-changed` is a composed event
> that denotes `lockType` and `status`(change pin1 or pin2), so its a gaia
> event and we have to handle it.

Thanks Fred. I was just about to reply the same opinion.

(Those card lock function names are really complicated...)

Comment 22

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8673017 [details] [review]
[gaia] gasolin:issue-1205596 > mozilla-b2g:master

Code looks good to me, thanks.

Comment 23

[[e-mail]]

merged https://github.com/mozilla-b2g/gaia/commit/6ecf254ed05f6b7a1d064307519257bc5d99a580

thanks!

Comment 24

[Norry.L.F(Leave from Mozilla)]

Hi Shally,

Verifyme please.

Comment 25

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: No alert "An unknown error occurred" pops up when user enters wrong PIN 2 and then changes to new PIN2 successfully.
See attachment: verified_Flame_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20151014150203
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151014.183316
Firmware Date          Wed Oct 14 18:33:28 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20151014225836
Gaia Revision          c64d6e345aa477f2a24b676e84a47020a00d015d
Gaia Date              2015-10-14 15:54:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4f4615ffec6a6a7ec40ff61ffda90a46c53f8d31
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151014.221548
Firmware Date          Wed Oct 14 22:15:56 UTC 2015
Bootloader             s1

Comment 26

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.5.3gp