Closed Bug 1205635 Opened 5 years ago Closed 5 years ago

Don't define Bluetooth interface methods in header

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

Product:
Firefox OS Graveyard
Component:
Bluetooth
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox44 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S8 (02Oct)
Tracking Flags:
Tracking Status
firefox44 --- fixed

People

(Reporter: tzimmermann, Assigned: tzimmermann)

References

Details

Attachments

(1 file)

[01] Bug 1205635: Don't define methods of Bluetooth backend interfaces in header
47.55 KB, patch
ben.tian
: review+
Details | Diff | Splinter Review 
Most Bluetooth interface methods are defined in BluetoothInterface.h. They are placeholders and not usually called, and they cannot be inlined because they are virtual. Yet they are created in every object file that instantiates the respective class, and the linker has to sort out duplicates afterwards.

We should move the placeholder methods into the source file to simplify the header.
Assignee: nobody → tzimmermann
Status: NEW → ASSIGNED
Comment on attachment 8662373 [details] [diff] [review]
[01] Bug 1205635: Don't define methods of Bluetooth backend interfaces in header

Review of attachment 8662373 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8662373 - Flags: review?(btian) → review+
Depends on: 1205253
https://hg.mozilla.org/mozilla-central/rev/1d43875e8522
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S8 (02Oct)
You need to log in before you can comment on or make changes to this bug.