1205657 - Remove "Set a Homepage" option from guest mode

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Tested with:
Device: Nexus 7 (Android 5.1)
Build: Firefox for Android 43.0a1 (2015-09-17)

Steps to reproduce:
1. Open Nightly and enter guest mode
2. Go to Menu -> Settings -> Customize -> Home

Actual results:
- "Set a Homepage" option is present

Expected results:
- "Set a Homepage" option should not be present in guest mode

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Does it really matter if the Homepage option is shown to Guests? Guest browsing does last longer than a simple session. You can quit Firefox and restart it, and you're still in Guest browsing.

Does the setting show the main user's homepage while in Guest browsing? That would be an issue.

I just don't want to get into a race to hide all settings.

Comment 2

[Teodora Vermesan (:TeoVermesan)]

If I go to normal browsing and set "google.com" as a homepage, then go to guest mode, "google.com" is not shown as home page, "about:home" is displayed.

In guest mode, if I go to  Menu -> Settings -> Customize -> Home and set a homepage (facebook.com for example), every time I open a new tab, about:home is displayed.

If I quit Nightly and reopen it, Nightly will open in guest mode, with facebook.com displayed.

Comment 3

[:Margaret Leibovic]

(In reply to Teodora Vermesan (:TeoVermesan) from comment #2)
> If I go to normal browsing and set "google.com" as a homepage, then go to
> guest mode, "google.com" is not shown as home page, "about:home" is
> displayed.

That makes sense to me. I consider a homepage pref similar to browsing history - something I wouldn't want a guest browsing user to see.

> In guest mode, if I go to  Menu -> Settings -> Customize -> Home and set a
> homepage (facebook.com for example), every time I open a new tab, about:home
> is displayed.

That's the expected behavior, we don't show the homepage in new tabs.

> If I quit Nightly and reopen it, Nightly will open in guest mode, with
> facebook.com displayed.

That's what mfinkle mentioned, that you need to explicitly quit guest browsing to get out of it.

I think this all sounds fine to me, and I'd prefer to not add more special case logic for guest browsing.

Barbara, what do you think?

Comment 4

[Barbara Bermes [:barbara] - NI please!]

Yes, I'm fine with the findings and observations.

The only thing we need to discuss is 

> In guest mode, if I go to  Menu -> Settings -> Customize -> Home and set a
> homepage (facebook.com for example), every time I open a new tab, about:home
> is displayed.

But that will be covered here: https://bugzilla.mozilla.org/show_bug.cgi?id=1206155 and should not block this bug.

Comment 5

[:Margaret Leibovic]

I think it's fine to keep this setting in guest mode, especially since I think we should keep it for restricted profiles. Let's not add another restriction and more special-case logic just for guest mode.