1205692 - Open in new tab context menu should open private tab when triggered from a private tab

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Stephan Leroux [:sleroux]]

When long pressing on a link, the context menu that displays Open New Tab should display Open New Private Tab and open a private tab if we are triggering it from a private tab.

Comment 1

[James Hugman [:jhugman] [@jhugman]]

Attachment: New private tab added, shown in both private and normal.

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Attachment: Screen shot of context menu in non-private browsing

Comment 3

[James Hugman [:jhugman] [@jhugman]]

Attachment: Screen shot of context menu in private browsing

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8664311 [details] [review]
New private tab added, shown in both private and normal.

Looks good! Just need to remove the temp string I added from UIConstants so we don't have it in two places.

Comment 5

[Robin Andersen [:tecgirl]]

Comment on attachment 8664313 [details]
Screen shot of context menu in non-private browsing

LGTM! ++ for AT

Comment 6

[Robin Andersen [:tecgirl]]

Comment on attachment 8664317 [details]
Screen shot of context menu in private browsing

OK, one nit: "Open in New Private Tab" instead of "Open In New Private Tab" (de-capitalize 'In'). Same goes for "Open in New Tab".

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Ok; trivial change to change the capitalization in code.

However: NSLocalizedStrings are case sensitive, and string freeze.

sleroux: This isn't something we want to give to the localizers to fix. Other than not landing this feature, are there any options?

Comment 8

[Stephan Leroux [:sleroux]]

I think it might be too late but you can double check with st3fan/flod about it.

Comment 9

[Richard Newman [:rnewman]]

File a follow-up to change the string capitalization, and land it.

Comment 10

[James Hugman [:jhugman] [@jhugman]]

Follow up bug https://bugzilla.mozilla.org/show_bug.cgi?id=1210185 to fix the capitalization.

Comment 11

[Catalin Suciu [:csuciu]]

Verifying as fixed on the current TestFlight build (1104)