Closed
Bug 1205706
Opened 9 years ago
Closed 9 years ago
Include endpoint=ENDPOINT query parameter in fxa-content-server requests from Fennec
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox43 fixed)
RESOLVED
FIXED
Firefox 43
Tracking | Status | |
---|---|---|
firefox43 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
Details
Attachments
(2 files)
This ticket tracks feeding an `endpoint` parameter through the native/web activity <intent-filter> switches through to about:accounts and then on to the fxa-content-server request. The idea is to track how the user arrives at about:accounts and reflect that to the fxa-content-server, so we can collect metrics server-side. Potential `endpoint` values: 'firstrun', 'preferences', 'notification', 'remotetabspanel', etc. Don't need to get too fine-grained here.
Assignee | ||
Comment 1•9 years ago
|
||
I discussed a little with vladikoff on IRC. He showed a list of maybe 10 items from metrics: http://v14d.com/i/55fb132b649ff.jpg. stomlinson: should I use a subset of these values for Fennec? Should I use distinct values so we can distinguish Fennec from Desktop? vladikoff is not certain the 'context' parameter makes it to the metrics backend (Heka?).
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Flags: needinfo?(stomlinson)
Assignee | ||
Comment 2•9 years ago
|
||
Bug 1205706 - Part 1: Pass-through white-listed intent extras to about:accounts. r?sebastian Pretty straight-forward. It's possible that getStringExtra is not safe in the face of malicious data; the worst we might expect is a crash on the Java side; a large memory allocation on the JS side; or significant URL data transfer. The first is valuable because we'd see abusers in crash-stats; and the second two are already possible when opening any URL.
Attachment #8662598 -
Flags: review?(s.kaspari)
Assignee | ||
Comment 3•9 years ago
|
||
Bug 1205706 - Part 2: Add entrypoint parameter to selected Firefox Account activities. r?sebastian This list is not meant to be exhaustive. There are many ways to get to the Get Started activity; not all of them are interesting. We're just trying to capture the significant entrypoints, like firstrun and preferences.
Attachment #8662599 -
Flags: review?(s.kaspari)
Comment 4•9 years ago
|
||
(In reply to Nick Alexander :nalexander from comment #1) > I discussed a little with vladikoff on IRC. He showed a list of maybe 10 > items from metrics: http://v14d.com/i/55fb132b649ff.jpg. > > stomlinson: should I use a subset of these values for Fennec? Should I use > distinct values so we can distinguish Fennec from Desktop? vladikoff is not > certain the 'context' parameter makes it to the metrics backend (Heka?). `context` is written to both Heka[1] and StatsD[2]. Vlad has a point about adding a `fennec` prefix to help with metrics, but that seems an awful lot like a metrics implementation detail though that you shouldn't have to worry about. If we need to namespace the entrypoint, we should be able to do that on our side. Name re-use would be great because the meaning of each name is already understood. If you need additional names, or a 1:1 mapping of a particular name doesn't quite fit, don't hesitate to add new ones. [1] - https://github.com/mozilla/fxa-content-server/blob/63771bea8cab08ef6ae4d14d5d262e44100f45a6/server/lib/metrics-collector-stderr.js#L102 [2] - https://github.com/mozilla/fxa-content-server/blob/63771bea8cab08ef6ae4d14d5d262e44100f45a6/server/lib/statsd-collector.js#L33
Flags: needinfo?(stomlinson)
Updated•9 years ago
|
Attachment #8662598 -
Flags: review?(s.kaspari) → review+
Comment 5•9 years ago
|
||
Comment on attachment 8662598 [details] MozReview Request: Bug 1205706 - Part 1: Pass-through white-listed intent extras to about:accounts. r?sebastian https://reviewboard.mozilla.org/r/19643/#review17679 ::: mobile/android/base/fxa/activities/FxAccountWebFlowActivity.java:60 (Diff revision 1) > - ABOUT_ACCOUNTS + "?action=" + action + extras); > + final StringBuilder sb = new StringBuilder(); I wonder if the following code would be simpler or more readable by using Uri.Builder. But I can live with the StringBuilder approach too.
Comment 6•9 years ago
|
||
Comment on attachment 8662599 [details] MozReview Request: Bug 1205706 - Part 2: Add entrypoint parameter to selected Firefox Account activities. r?sebastian https://reviewboard.mozilla.org/r/19645/#review17681
Attachment #8662599 -
Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/70f459b00b88 https://hg.mozilla.org/integration/fx-team/rev/49dda13aabe2
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/70f459b00b88 https://hg.mozilla.org/mozilla-central/rev/49dda13aabe2
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•