Closed Bug 1205744 Opened 5 years ago Closed 5 years ago

Remove js::IsContextRunningJS

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla44
Tracking Status
firefox44 --- fixed

People

(Reporter: Ms2ger, Assigned: sajitk, Mentored)

Details

(Whiteboard: [lang=c++])

Attachments

(1 file)

js::IsContextRunningJS is redundant with JS_IsRunning (ever since bug 881902).

We should:

* remove its declaration from js/src/jsfriendapi.h;
* remove its definition from js/src/jsfriendapi.cpp;
* replace its single caller in dom/base/nsObjectLoadingContent.cpp (nsObjectLoadingContent::ScriptRequestPluginInstance) with JS_IsRunning(aCx).
Whiteboard: [lang=c++]
Attached patch 1205744.patchSplinter Review
Please find attached patch with the changes.
Comment on attachment 8663243 [details] [diff] [review]
1205744.patch

Thank you, looking great!
Attachment #8663243 - Flags: review?(hv1989)
Comment on attachment 8663243 [details] [diff] [review]
1205744.patch

Review of attachment 8663243 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks
Attachment #8663243 - Flags: review?(hv1989) → review+
I think this doesn't really need a try run; lemme know if I should do one anyway.
Assignee: nobody → sajitk
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/16727f8bf69b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in before you can comment on or make changes to this bug.