Closed
Bug 1205767
Opened 9 years ago
Closed 9 years ago
the memory returned by calls to decode_ec_params in nsKeygenHandler.cpp is leaked
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla44
People
(Reporter: keeler, Assigned: keeler)
Details
Attachments
(1 file)
decode_ec_params allocates memory and returns it. The caller (nsKeygenFormProcessor::GetPublicKey) never frees it, but it does pass it in to PK11_GenerateKeyPairWithFlags. It may be that the memory is reachable from what PK11_GenerateKeyPairWithFlags returns and is appropriately cleaned up when that gets cleaned up, but I doubt it.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Looking closer (and consulting similar code), it appears this memory is in fact leaked.
Summary: investigate if the calls to decode_ec_params in nsKeygenHandler.cpp leak memory → the memory returned by calls to decode_ec_params in nsKeygenHandler.cpp is leaked
![]() |
Assignee | |
Comment 2•9 years ago
|
||
bug 1205767 - prevent memory leak when generating an EC key with <keygen> r?ttaubert
Attachment #8667476 -
Flags: review?(ttaubert)
![]() |
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dkeeler
Updated•9 years ago
|
Attachment #8667476 -
Flags: review?(ttaubert) → review+
Comment 3•9 years ago
|
||
Comment on attachment 8667476 [details]
MozReview Request: bug 1205767 - prevent memory leak when generating an EC key with <keygen> r?ttaubert
https://reviewboard.mozilla.org/r/20761/#review18703
Yeah, that seems the right thing to do. Happy to give r+, but I'm unfortunately not a peer.
![]() |
Assignee | |
Comment 5•9 years ago
|
||
Thanks for the review. Since I'm a peer, I delegated the review to you :)
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox44:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
You need to log in
before you can comment on or make changes to this bug.
Description
•