1205789 - Changing time range doesn't work in perfherder graphs

Status: RESOLVED FIXED

(Tree Management :: Perfherder, defect)

Description

[William Lachance (:wlach)]

At some point the time range selector in perfherder graphs broke. I need to fix it.

Comment 1

[William Lachance (:wlach)]

Attachment: PR

This actually got fixed by accident in bug 1206097 as well, but it's worth addressing separately here as well, as the code was rather confusing.

Comment 2

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9f89bdb01ab9953d234b5b927e092f6f2527606b
Bug 1205789 - Fix and clarify changing time range in perfherder graphs

https://github.com/mozilla/treeherder/commit/fdff333b8f609bc67e7646dd6338e01fa754b762
Merge pull request #974 from wlach/1205789

 	Bug 1205789 - Fix and clarify changing time range in perfherder graphs

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/71f7fa01f3fcfccf10ccc655a3111b7d3f9757f8
Bug 1205789 - Followup fixes to changing time range

Comment 4

[William Lachance (:wlach)]

There are still issues here. I.e. adding a series then pressing the back button fails.

The overall problem I think is that we're (still) not handling the "time range changed" properly, which is to say that we're still firing it when the page is first (re)loaded, rather than when the user actually changes it.

Let's fix that and also leave out the timerange parameter when it has its default value.

Comment 5

[William Lachance (:wlach)]

Attachment: Bug 1205789 - Fix back/forward button in perfherder graphs

Ok, I think I've finally nailed it this time. The back/forward button should always work in perfherder graphs, and there should be no spurious "navigation" when the view is first loaded.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8668557 [details] [review]
Bug 1205789 - Fix back/forward button in perfherder graphs

one small comment, otherwise this seems to be valid!

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/834f0d090cf5033ce75ad7dacb47644d71d6d71a
Bug 1205789 - Fix back/forward button in perfherder graphs

Comment 8

[William Lachance (:wlach)]

Hopefully this is fixed for good now. :)