Changing time range doesn't work in perfherder graphs

RESOLVED FIXED

Status

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: wlach, Assigned: wlach)

Tracking

Details

Attachments

(2 attachments)

At some point the time range selector in perfherder graphs broke. I need to fix it.
Created attachment 8662960 [details] [review]
PR

This actually got fixed by accident in bug 1206097 as well, but it's worth addressing separately here as well, as the code was rather confusing.
Assignee: nobody → wlachance
Attachment #8662960 - Flags: review?(jmaher)
Attachment #8662960 - Flags: review?(jmaher) → review+

Comment 2

3 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/9f89bdb01ab9953d234b5b927e092f6f2527606b
Bug 1205789 - Fix and clarify changing time range in perfherder graphs

https://github.com/mozilla/treeherder/commit/fdff333b8f609bc67e7646dd6338e01fa754b762
Merge pull request #974 from wlach/1205789

 	Bug 1205789 - Fix and clarify changing time range in perfherder graphs
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
There are still issues here. I.e. adding a series then pressing the back button fails.

The overall problem I think is that we're (still) not handling the "time range changed" properly, which is to say that we're still firing it when the page is first (re)loaded, rather than when the user actually changes it.

Let's fix that and also leave out the timerange parameter when it has its default value.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Created attachment 8668557 [details] [review]
Bug 1205789 - Fix back/forward button in perfherder graphs

Ok, I think I've finally nailed it this time. The back/forward button should always work in perfherder graphs, and there should be no spurious "navigation" when the view is first loaded.
Attachment #8668557 - Flags: review?(jmaher)
Comment on attachment 8668557 [details] [review]
Bug 1205789 - Fix back/forward button in perfherder graphs

one small comment, otherwise this seems to be valid!
Attachment #8668557 - Flags: review?(jmaher) → review+
Hopefully this is fixed for good now. :)
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.