Closed
Bug 1205800
Opened 10 years ago
Closed 10 years ago
Add animations/better transitions when toggling private mode in the tabs tray
Categories
(Firefox for iOS :: General, defect)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 1.1+ | --- |
People
(Reporter: sleroux, Assigned: sleroux)
Details
Attachments
(1 file)
|
48 bytes,
text/x-github-pull-request
|
bnicholson
:
review+
dhenein
:
ui-review+
|
Details | Review |
Creating a bug to keep track of adding some spice to the tab tray. Some ideas from :darrin include:
* When toggling between private/normal modes, have the current tab list scale down to 90% while fading out and have the new tabs scale up from 90% and fade in to achieve a cross-fade animation
* When toggling, the purple background behind the mask button scales up to encompass the mask button, then expands across to also include the + button
Updated•10 years ago
|
| Assignee | ||
Updated•10 years ago
|
Assignee: nobody → sleroux
| Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8665590 -
Flags: ui-review?(dhenein)
Attachment #8665590 -
Flags: review?(bnicholson)
Comment 2•10 years ago
|
||
Comment on attachment 8665590 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1101
Looks great!
Attachment #8665590 -
Flags: review?(bnicholson) → review+
Comment 3•10 years ago
|
||
Comment on attachment 8665590 [details] [review]
https://github.com/mozilla/firefox-ios/pull/1101
This looks great, not sure if im settled on the transition from normal<>private tabs, but lets land this for now.
Also I think the purple circle highlighting the mask icon in PBM is too large. I believe the spec has it at 32px, ui-review+ with that change.
Attachment #8665590 -
Flags: ui-review?(dhenein) → ui-review+
| Assignee | ||
Comment 4•10 years ago
|
||
Fixed nit and landed.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•