Closed Bug 1205814 Opened 4 years ago Closed 4 years ago

devtools eslint config -vs- global lexical scope

Categories

(DevTools :: General, defect)

defect
Not set

Tracking

(firefox44 fixed)

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- fixed

People

(Reporter: tromey, Assigned: miker)

Details

Attachments

(2 obsolete files)

Bug 1202902 mass-changed top-level "let" and "const" to "var".
See that bug, and bug 589199, for the explanation.

After this change, the devtools eslint config complains about these
top-level "var"s.  However, it should not, as we're required to use them.
We can write a rule to prevent complaining about these top level vars.
Assignee: nobody → mratcliffe
Bug 1205814 - mozilla eslint plug: allow top level var only r?=pbrosset
Comment on attachment 8678857 [details]
MozReview Request: Bug 1205814 - mozilla eslint plug: allow top level var only r?=pbrosset

Bug 1205814 - mozilla eslint plug: allow top level var only r?=pbrosset
Attachment #8678857 - Flags: review?(pbrosset)
Comment on attachment 8678857 [details]
MozReview Request: Bug 1205814 - mozilla eslint plug: allow top level var only r?=pbrosset

https://reviewboard.mozilla.org/r/23265/#review20731

Nice, thanks for working on this. This has been bugging me in SublimeText for a while.
This simple rule seems to do the trick nicely.
Attachment #8678857 - Flags: review?(pbrosset) → review+
Missed a brief description in rst docs r?=pbrosset
Attachment #8678863 - Flags: review?(pbrosset)
Attachment #8678863 - Flags: review?(pbrosset) → review+
Comment on attachment 8678863 [details]
MozReview Request: Missed a brief description in rst docs r?=pbrosset

https://reviewboard.mozilla.org/r/23267/#review20733
https://hg.mozilla.org/mozilla-central/rev/da7f20651f16
https://hg.mozilla.org/mozilla-central/rev/21b2dfbe1f24
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Attachment #8678857 - Attachment is obsolete: true
Attachment #8678863 - Attachment is obsolete: true
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.